Open
Conversation
…ngth (#20840) ## Summary - Fixes index-out-of-bounds when using notes with arrays by accounting for AES PKCS#7 padding expansion (16 bytes) when computing `MESSAGE_PLAINTEXT_LEN` - Updates `MAX_NOTE_PACKED_LEN` (9 -> 8) and `MAX_EVENT_SERIALIZED_LEN` (11 -> 10) in both Noir and TypeScript to match the corrected capacity - Adds boundary tests for max-size and oversized messages, notes, and encryption plaintexts Fixes F-336 Fixes #20737
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1.
## Summary - Increases the mainnet `AZTEC_LOCAL_EJECTION_THRESHOLD` from 162,000 TST to 190,000 TST in `network-defaults.yml`. ## Test plan - [ ] Verify generated config files reflect the updated threshold after regeneration
1 task
…ts (v4) (#20982) **Problem**: The `mainnet_compatibility.test.ts` test checks that `protocolContractsHash` matches a hardcoded mainnet value. We missed protocol contracts while pinning protocol circuits. **Solution**: - When `pinned-protocol-contracts.tar.gz` exists in the `noir-contracts/` directory, the build extracts pre-compiled protocol contract artifacts and skips compiling them - Adds `./bootstrap.sh pin-protocol-contracts` command to build protocol contracts and create the tarball
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(aztec-nr): account for AES PKCS#7 padding in message plaintext length (#20840)
feat: remove epk sign from message payload (#20926)
chore: increase mainnet local ejection threshold to 190k (#20884)
END_COMMIT_OVERRIDE