chore: add Renovate auto-update for buf version#8981
Open
abigailliang-aks-sig-node wants to merge 2 commits into
Open
chore: add Renovate auto-update for buf version#8981abigailliang-aks-sig-node wants to merge 2 commits into
abigailliang-aks-sig-node wants to merge 2 commits into
Conversation
Extract pinned buf version into aks-node-controller/.buf-version and add a Renovate custom regex manager to track bufbuild/buf Docker image releases automatically.
abigailliang-aks-sig-node
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
karenychen,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright,
titilambert,
xuexu6666 and
zachary-bailey
as code owners
July 17, 2026 22:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the pinned buf CLI version for the aks-node-controller module into a dedicated .buf-version file and wires Renovate to automatically propose updates when new bufbuild/buf Docker image tags are released.
Changes:
- Moved the pinned buf version into
aks-node-controller/.buf-versionas a single source of truth. - Updated
aks-node-controller/Makefileto readBUF_VERSIONfrom.buf-version. - Added a Renovate regex custom manager to track and update
.buf-versionfrom thebufbuild/bufDocker datasource.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aks-node-controller/Makefile | Reads buf version from .buf-version for the dockerized buf invocation. |
| aks-node-controller/.buf-version | New single-source file containing the pinned buf version. |
| .github/renovate.json | Adds a custom regex manager to update .buf-version automatically via Renovate. |
| # Run buf in docker, mounting the full repo into the container | ||
| # Emulate running "buf" in the current directory | ||
| BUF_VERSION = 1.71.0 | ||
| BUF_VERSION = $(shell cat $(CURDIR)/.buf-version) |
The workflow was grepping BUF_VERSION from Makefile, which now contains a $(shell ...) expression instead of a literal version. Read directly from .buf-version and add it to the paths trigger.
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| # Run buf in docker, mounting the full repo into the container | ||
| # Emulate running "buf" in the current directory | ||
| BUF_VERSION = 1.71.0 | ||
| BUF_VERSION = $(shell cat $(CURDIR)/.buf-version) |
Comment on lines
+24
to
+26
| - name: Read buf version | ||
| id: buf-version | ||
| run: echo "version=$(grep '^BUF_VERSION' aks-node-controller/Makefile | cut -d'=' -f2 | tr -d ' ')" >> "$GITHUB_OUTPUT" | ||
| run: echo "version=$(cat aks-node-controller/.buf-version)" >> "$GITHUB_OUTPUT" |
Comment on lines
+835
to
+842
| "matchStringsStrategy": "any", | ||
| "matchStrings": [ | ||
| "(?<currentValue>\\S+)" | ||
| ], | ||
| "depNameTemplate": "bufbuild/buf", | ||
| "datasourceTemplate": "docker", | ||
| "extractVersionTemplate": "^(?<version>.*)$" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aks-node-controller/.buf-versionas a single source of truthMakefileto read version from.buf-versionvia$(shell cat ...)bufbuild/bufDocker image releases automaticallyTest plan
make proto-generateworks with version read from.buf-version)npx -p renovate@43 renovate --dry-run --platform=localsuccessfully matchedaks-node-controller/.buf-versionand queried Docker Hub forbufbuild/buftags