chore(deps): bump dompurify from 3.4.0 to 3.4.11#9298
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | No change needed |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | No change needed |
| Contributors | ✅ | Optional: add human contributor names if applicable |
| Screenshots/Videos | ✅ | No change needed |
This PR passes review for title/body compliance. The advised risk level matches the submitted risk level (medium).
Last updated: Tue, 07 Jul 2026 17:56:55 GMT
📊 Coverage CheckNo source files changed in this PR. |
|
@dependabot rebase |
c640c28 to
f2e9007
Compare
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.0 to 3.4.11. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.0...3.4.11) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.11 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
f2e9007 to
80956ea
Compare
…11 compat DOMPurify >= 3.4.11 is incompatible with happy-dom: sanitize() strips the outermost element, so getDomFromHtmlEditorString().firstElementChild is null and isHtmlStringValueSafeForLexical throws on querySelectorAll. jsdom and real browsers preserve the element structure, so this test file now runs under jsdom to match production behavior and unblock the dompurify 3.4.0 -> 3.4.11 bump. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Pushed a follow-up commit (651bb39) to unblock this bump. Why the dompurify 3.4.0 -> 3.4.11 bump broke CI: I reproduced this in isolation across happy-dom 15.x -> 20.8.9 (all affected) and confirmed jsdom and real browsers preserve the element structure for 3.4.11 - i.e. production is unaffected; only the happy-dom unit-test environment is. Fix: run this one DOM-sanitization test file under |
rllyy97
left a comment
There was a problem hiding this comment.
dompurify 3.4.11 clears the outstanding dompurify advisory. The happy-dom test incompatibility is fixed by running util.spec.ts under jsdom (verified 111/111 locally). Production behavior is unchanged. Approving.
Commit Type
Risk Level
What & Why
Bumps dompurify from 3.4.0 to 3.4.11 — an upstream security/maintenance release that clears the outstanding DOMPurify advisory and brings
npm auditto zero.The raw bump broke
designer-uiCI because that project's vitest suite runs under happy-dom, and DOMPurify >= 3.4.11 is incompatible with happy-dom:DomPurify.sanitize()strips the outermost element (e.g. the wrapper<div>added bygetDomFromHtmlEditorString). That makesfirstElementChildreturnnull, soisHtmlStringValueSafeForLexicalthrowsCannot read properties of null (reading 'querySelectorAll')(13 failing tests inutil.spec.ts).This was reproduced in isolation across happy-dom 15.x → 20.8.9 (all affected). jsdom and real browsers preserve the element structure for 3.4.11, so production is unaffected — only the happy-dom unit-test environment is. The fix runs that one DOM-sanitization test file under
@vitest-environment jsdom(already a repo devDependency) to match production behavior. No source/production code changes.Impact of Change
libs/designer-ui/src/lib/html/plugins/toolbar/helper/__test__/util.spec.tsnow runs under@vitest-environment jsdombecause DOMPurify 3.4.11 is incompatible with happy-dom for that path.Test Plan
util.spec.tspasses 111/111 locally under jsdom with dompurify 3.4.11; happy-dom incompatibility reproduced across happy-dom 15.x–20.8.9.Contributors
Dependency validation and test-environment fix assisted by GitHub Copilot.
Screenshots/Videos
N/A — dependency + test-environment change only.
Bumps dompurify from 3.4.0 to 3.4.11.
Release notes
Sourced from dompurify's releases.
... (truncated)
Commits
0cae518release: 3.4.11 (#1494)6ee5716release: 3.4.10 (#1478)5210247release: 3.4.9 (#1459)bcdd828release: 3.4.8 (#1439)ca30f07release: 3.4.7 (#1414)bb7739erelease: 3.4.6 (#1394)011b0c7release: 3.4.5 (#1382)5817ad9release: 3.4.4 (#1374)520edb0release: 3.4.3 (#1352)6f67fd3Sync/3.4.2 (#1322)Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.