Skip to content

fix(vscode): WORKFLOW_CODEFUL_ENABLED source of truth (#9335) [hotfix/v5.970]#9359

Merged
lambrianmsft merged 1 commit into
Azure:hotfix/v5.970from
lambrianmsft:cherry-pick/v5.970/9335
Jul 2, 2026
Merged

fix(vscode): WORKFLOW_CODEFUL_ENABLED source of truth (#9335) [hotfix/v5.970]#9359
lambrianmsft merged 1 commit into
Azure:hotfix/v5.970from
lambrianmsft:cherry-pick/v5.970/9335

Conversation

@lambrianmsft

@lambrianmsft lambrianmsft commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Byte-for-byte cherry-pick of #9335 (1afcdc40) — make WORKFLOW_CODEFUL_ENABLED the source of truth; remove redundant telemetry/context.

  • git cherry-pick onto the hotfix tip: 23 files, 0 conflicts, 0 graphify.
  • v5.970 does not carry fix(vscode): restore codeful bundle version setting #9232, so this matches main exactly. Residual diffs vs main in constants.ts/main.ts are expected hotfix base-divergence; 9335's delta applied faithfully.

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Updates 'isCodeful' checks to use the WORKFLOW_CODEFUL_ENABLED app setting as source of truth rather than csproj content, which is a less reliable/standard indicator.

Impact of Change

  • Users: May fix codeful project detection in some edge case scenarios
  • Developers: Removes code for redundant telemetry and extension context
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

…truth, remove redundant telemetry/context (Azure#9335)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): WORKFLOW_CODEFUL_ENABLED source of truth (#9335) [hotfix/v5.970]
  • Issue: None; this is a clear, specific title that describes the change well.
  • Recommendation: No change needed.

Commit Type

  • Properly selected (fix).
  • Only one commit type is checked, which is correct.

Risk Level

  • Properly selected (Low).
  • Advised risk from the diff: Low. The change is scoped to replacing codeful detection logic, updating constants, and aligning tests/consumers. The submitter's risk assessment matches the diff.

What & Why

  • Current: Updates 'isCodeful' checks to use the WORKFLOW_CODEFUL_ENABLED app setting as source of truth rather than csproj content, which is a less reliable/standard indicator.
  • Issue: None; this is concise and accurate.
  • Recommendation: No change needed.

Impact of Change

  • The section is present and gives a reasonable summary of affected users, developers, and system impact.
  • Recommendation:
    • Users: Good as-is.
    • Developers: Good as-is.
    • System: Good as-is.

Test Plan

  • Succeeds: unit tests are present in the diff, so the test plan is adequately backed.
  • No E2E tests are required since unit tests exist.

Contributors

  • Present: @andrew-eldridge.
  • Good to keep for credit.

⚠️ Screenshots/Videos

  • Not required here. This is not obviously a visual/UI change requiring screenshots.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level No change needed
What & Why No change needed
Impact of Change No change needed
Test Plan No change needed
Contributors No change needed
Screenshots/Videos ⚠️ Not required for this change

This PR passes review for title/body compliance. The submitted risk level matches the diff, and the test plan is supported by unit tests in the PR.


Last updated: Thu, 02 Jul 2026 03:07:59 GMT

@lambrianmsft lambrianmsft merged commit 31faed0 into Azure:hotfix/v5.970 Jul 2, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants