Fix type annotation warnings and test warnings (issue #442)#1459
Merged
romanlutz merged 1 commit intoAzure:mainfrom Mar 13, 2026
Merged
Fix type annotation warnings and test warnings (issue #442)#1459romanlutz merged 1 commit intoAzure:mainfrom
romanlutz merged 1 commit intoAzure:mainfrom
Conversation
- Add -> None return type to TranslationConverter.__init__ - Add Optional[str] annotation to AzureBlobStorageTarget._sas_token - Fix _client_async type to Optional[AsyncContainerClient] - Replace unclosed open().read() with Path.read_bytes() in test_tts_target - Use context manager for Image.open() in test_leakage_scenario - Replace deprecated .role with .api_role in test_websocket_copilot_target - Use 32+ byte JWT key to fix InsecureKeyLengthWarning in tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jsong468
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #442