[AKS] aks-preview: bump minCliCoreVersion to 2.85.0 for ACNS performance compatibility#10071
Open
FumingZhang wants to merge 1 commit into
Open
[AKS] aks-preview: bump minCliCoreVersion to 2.85.0 for ACNS performance compatibility#10071FumingZhang wants to merge 1 commit into
FumingZhang wants to merge 1 commit into
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the aks-preview extension release metadata to prevent runtime crashes on older Azure CLI cores by enforcing a higher minimum supported azure-cli core version.
Changes:
- Bump
aks-previewextension version to21.0.0b9. - Raise
azext.minCliCoreVersionfrom2.76.0to2.85.0. - Add a release note entry documenting the minimum core version change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumps the extension package version to 21.0.0b9. |
| src/aks-preview/HISTORY.rst | Adds release notes for 21.0.0b9, including the new minimum CLI core requirement. |
| src/aks-preview/azext_aks_preview/azext_metadata.json | Raises azext.minCliCoreVersion to 2.85.0 to prevent loading on incompatible cores. |
Comment on lines
1
to
3
| { | ||
| "azext.minCliCoreVersion": "2.76.0", | ||
| "azext.minCliCoreVersion": "2.85.0", | ||
| "azext.isPreview": true, |
…nce compatibility
0c80fd2 to
6b64bcb
Compare
Collaborator
|
AKS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create,az aks update(network profile / ACNS setup path)Description
Raise
azext.minCliCoreVersionforaks-previewfrom2.76.0to2.85.0and bump the extension to21.0.0b9.Since
aks-preview20.0.0b5 (PR #9779),AKSPreviewManagedClusterContext.get_acns_enablement()returns four values (adding the ACNS performance / datapath-acceleration flag). The extension'sset_up_network_profile()callssuper().set_up_network_profile(), and the baseacsmodule only started consuming that fourth value (viaget_acns_enablement_with_perf()) in azure-cli core 2.85.0.On any core older than
2.85.0, the baseset_up_network_profile()still unpacks three values:so every
az aks create/az aks updatefails with:Because the manifest advertised
minCliCoreVersion = 2.76.0, the extension could be installed on incompatible cores and crashed at runtime (e.g.aks-preview 21.0.0b6onazure-cli 2.82.0). Raising the floor makesazrefuse to load the extension on an incompatible core (prompting an upgrade) instead of crashing mid-command.20.0.0b5>= 2.85.0This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style aks-previewlocally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)About Extension Publish
Only
setup.py(version) andHISTORY.rstare updated for the release;src/index.jsonis intentionally left untouched.