{Compute} Migrate vm size completer of calling Compute module to aaz-based implementation#32938
Open
william051200 wants to merge 2 commits intoAzure:devfrom
Open
{Compute} Migrate vm size completer of calling Compute module to aaz-based implementation#32938william051200 wants to merge 2 commits intoAzure:devfrom
william051200 wants to merge 2 commits intoAzure:devfrom
Conversation
william051200
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the VM size completer backend from the mgmt.compute SDK client to an AAZ-based implementation in the VM command module.
Changes:
- Replaced
virtual_machine_sizes.list(location)usage with AAZVMListSizesinvocation for retrieving VM sizes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
300
to
+304
| def get_vm_sizes(cli_ctx, location): | ||
| return list(_compute_client_factory(cli_ctx).virtual_machine_sizes.list(location)) | ||
| from .operations.vm import VMListSizes | ||
| return VMListSizes(cli_ctx=cli_ctx)(command_args={ | ||
| 'location': location | ||
| }) |
There was a problem hiding this comment.
get_vm_sizes previously returned SDK VirtualMachineSize objects (used by the get_vm_size_completion_list completer via r.name). The new AAZ VMListSizes output deserializes to a list of dicts (with a 'name' key), so callers doing attribute access will break. To keep the completer working, either adapt get_vm_sizes to return objects with a .name attribute (e.g., map dicts to a simple object) or update the completer to use r['name'] consistently with other AAZ list outputs.
microsoft-github-policy-service
bot
added
the
Compute
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmDescription
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.