{Batchai} Migrate vm size completer of calling Compute module to aaz-based implementation#32948
Open
william051200 wants to merge 4 commits intoAzure:devfrom
Open
{Batchai} Migrate vm size completer of calling Compute module to aaz-based implementation#32948william051200 wants to merge 4 commits intoAzure:devfrom
william051200 wants to merge 4 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the BatchAI --vm-size completer to stop using the Compute SDK client factory and instead call the VM module’s AAZ-based implementation for listing VM sizes, aligning BatchAI with ongoing AAZ migration work.
Changes:
- Replaced
mgmt.computeclient usage withVMListSizes(AAZ-backed) to fetch VM sizes. - Adjusted the completer to extract size names from AAZ-deserialized dict output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az batchai cluster createaz batchai file-server createDescription
Migration from mgmt.compute to aaz-based
Updating vm list size version to 2024-11-01 to avoid breaking change
aaz Azure/aaz#967
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.