Repository navigation
[Containerapp] az containerapp job execution list: Fix incomplete paginated results - #34209
Korede (kokelowo) wants to merge 3 commits into
Conversation
Follow ARM continuation URLs and return complete execution history. Add an optional page-size argument with regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Thank you for your contribution Korede (@kokelowo)! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
🟡 Changes recommended
The introduced pageSize query parameter is absent from the selected ARM API contract.
1 open finding
What changed in this PR
Fixes Container App Job execution pagination while preserving output shape and continuation behavior.
Changes:
- Aggregates all ARM execution pages securely.
- Adds pagination tests and
--page-size. - Updates command help.
| File | Description |
|---|---|
_clients.py |
Implements pagination and continuation validation. |
custom.py |
Forwards and validates page size. |
_params.py |
Defines --page-size. |
_help.py |
Documents pagination usage. |
test_containerappjob_execution_pagination.py |
Tests pagination and failures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Please fix CI issues |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
az containerapp job execution list: Fix incomplete paginated results
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Keep automatic ARM continuation handling without exposing an undocumented query parameter. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Hi @Azure/x-engineering-agent |
X Engineering Agent ReportReview — Comments No confirmed semantic defects at head Copilot comment The client follows continuations through empty intermediate pages, preserves execution order, and returns the flat execution array through Test validation
Focused validation
The author reports 12 passing unit/recorded tests, help checks and removed-option rejection; these were not independently run here. The existing execution-list scenario asserts one or three results rather than multiple service pages. No recordings changed; existing recordings are Before merge, rerun Risk assessment — 16/100 · LowThe Low rating is driven by public CLI behavior.
Posted by x-engineering-agent (Reviewer) |

🤖 PR Validation — ❌ Action needed
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
Related command
az containerapp job execution listDescription
The command currently returns only the first page of execution history when ARM supplies a
nextLink.This change:
nextLinkand aggregates executions in server-provided order, including when an intermediate page is empty.No new flags or API-version changes are included.
Testing Guide
With repository source packages on
PYTHONPATH, the following command passed all 12 tests, covering pagination, error propagation, existing unit tests, and two recorded execution scenarios:Additional checks passed:
Both help commands omit the removed flag, and an argument-parsing check confirmed that the removed flag is rejected before an ARM request is made.
Reviewer usage example with placeholder resource names:
On a job with multiple execution pages, the command should return all executions, not just one.
History Notes
[Containerapp]
az containerapp job execution list: Follow ARM pagination to return all executionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.