[AutoPR azure-security-keyvault-secrets]-generated-from-SDK Generation - Java-6031743#48467
[AutoPR azure-security-keyvault-secrets]-generated-from-SDK Generation - Java-6031743#48467
Conversation
…yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: 'f6bd06be22baf3a18504ffef0f590230850953e5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6031743 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
… version, fix tsp-location.yaml - Restore NullPointerException bug fix dropped by auto-generation in CHANGELOG - Document new features: previousVersion field, outContentType parameter - Add V2025_06_01_PREVIEW and V2025_07_01 to SecretServiceVersion enum - Update getLatest() to return V2025_07_01 - Remove trailing whitespace from additionalDirectories in tsp-location.yaml
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…ed file, managed by TypeSpec generator
The PR's TypeSpec-generated code correctly removes the Accept header from purgeDeletedSecret (void/204 operation), but existing test recordings include Accept in purge requests. Adding Accept to the excluded headers list allows playback tests to work with both old recordings (that have Accept) and new code (that doesn't send it).
There was a problem hiding this comment.
Pull request overview
Updates azure-security-keyvault-secrets based on TypeSpec SDK generation for Key Vault Secrets (API version 2025-07-01), aligning repo configuration and generated models/client surfaces with the latest spec.
Changes:
- Update TypeSpec source location (
tsp-location.yaml) to the newspecification/keyvault/data-plane/Secretsdirectory and spec commit. - Add
previousVersionto generated secret response models and reflect it in the generated implementation client schema docs. - Update test proxy matcher exclusions and refresh
CHANGELOG.mdentries for the new generated changes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/keyvault/azure-security-keyvault-secrets/tsp-location.yaml | Points generation to new spec path/commit and updates additional directories. |
| sdk/keyvault/azure-security-keyvault-secrets/src/test/java/com/azure/security/keyvault/secrets/SecretClientTestBase.java | Adjusts playback-mode request matching by excluding the Accept header. |
| sdk/keyvault/azure-security-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/implementation/models/SecretBundle.java | Adds previousVersion field, getter, and JSON (de)serialization. |
| sdk/keyvault/azure-security-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/implementation/models/DeletedSecretBundle.java | Adds previousVersion field, getter, and JSON (de)serialization for deleted-secret model. |
| sdk/keyvault/azure-security-keyvault-secrets/src/main/java/com/azure/security/keyvault/secrets/implementation/models/ContentType.java | Introduces a generated MIME-type enum for supported content types. |
| sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md | Adds feature notes for previousVersion and outContentType, and updates the top entry header. |
| * The version of the previous certificate, if applicable. Applies only to certificates created after June 1, 2025. | ||
| * Certificates created before this date are not retroactively updated. |
There was a problem hiding this comment.
The new previousVersion documentation here refers to the "previous certificate", but the same feature is described in this PR's CHANGELOG as the "previous secret". Please verify the intended meaning from the service spec and make the wording consistent across docs (model field + getter + CHANGELOG), e.g., clarify whether this applies only to certificate-backed secrets or all secrets.
| * The version of the previous certificate, if applicable. Applies only to certificates created after June 1, 2025. | |
| * Certificates created before this date are not retroactively updated. | |
| * The version identifier of the previous secret, if applicable. Applies only to secrets created after June 1, 2025. | |
| * Secrets created before this date are not retroactively updated. |
| * The version of the previous certificate, if applicable. Applies only to certificates created after June 1, 2025. | ||
| * Certificates created before this date are not retroactively updated. | ||
| */ | ||
| @Generated | ||
| private String previousVersion; | ||
|
|
There was a problem hiding this comment.
The new previousVersion documentation here refers to the "previous certificate", but the same feature is described in this PR's CHANGELOG as the "previous secret". Please verify the intended meaning from the service spec and make the wording consistent across docs (model field + getter + CHANGELOG), e.g., clarify whether this applies only to certificate-backed secrets or all secrets.
| directory: specification/keyvault/data-plane/Secrets | ||
| commit: f6bd06be22baf3a18504ffef0f590230850953e5 | ||
| repo: Azure/azure-rest-api-specs | ||
| cleanup: true | ||
| additionalDirectories: | ||
| - specification/keyvault/Security.KeyVault.Common/ | ||
| - specification/keyvault/data-plane/Secrets/common |
There was a problem hiding this comment.
tsp-location.yaml diverges from the other Key Vault modules: it drops cleanup: true and the additionalDirectories entry no longer ends with a trailing /. Other Key Vault libraries keep cleanup: true and use trailing slashes for additionalDirectories paths (for example azure-security-keyvault-keys/tsp-location.yaml). Consider restoring cleanup: true and using specification/keyvault/data-plane/Secrets/common/ for consistency and to avoid tooling differences when resolving directory paths.
| ## 4.11.0-beta.1 (2026-03-19) | ||
|
|
||
| ### Features Added | ||
|
|
||
| ### Breaking Changes | ||
| - Added `previousVersion` property to `KeyVaultSecret` and related response models, which returns the version of the previous secret, if applicable. This field is only populated for secrets created after June 1, 2025. | ||
| - Added `outContentType` query parameter support to `getSecret` operations, enabling PFX to PEM format conversion for certificate-backed secrets. Available in service version `2025-07-01` and later. |
There was a problem hiding this comment.
The top CHANGELOG entry was changed from "(Unreleased)" to a specific date. In this repo, Key Vault packages keep the next version marked as "Unreleased" until the release is finalized (see azure-security-keyvault-keys/CHANGELOG.md). Also, this section removed the standard empty subsections (Breaking Changes/Other Changes). Consider reverting to the standard format and keeping the entry as Unreleased.
|
The failing check (ubuntu2404_125_FromSource_SkipRebuild_Verify) is caused by a test recording mismatch in the azure-compute-batch module, not by any changes in this PR. |
Configurations: 'specification/keyvault/data-plane/Secrets/tspconfig.yaml', API Version: 2025-07-01, SDK Release Type: stable, and CommitSHA: 'f6bd06be22baf3a18504ffef0f590230850953e5' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6031743 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.