Skip to content

Remove deprecated multi-agent workflow samples and update evaluation … - #48795

Open
Howie Leung (howieleung) wants to merge 1 commit into
feature/azure-ai-projects/vnextfrom
howie/reemit
Open

Remove deprecated multi-agent workflow samples and update evaluation …#48795
Howie Leung (howieleung) wants to merge 1 commit into
feature/azure-ai-projects/vnextfrom
howie/reemit

Conversation

@howieleung

Copy link
Copy Markdown
Member

…scripts with new role assignment parameters. Update YAML configuration for additional directories and commit reference.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…scripts with new role assignment parameters. Update YAML configuration for additional directories and commit reference.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown
Contributor
[Pilot] PR Pipeline Failure Analysis

What failed

Build: #6760396 (public)azure-ai-projects package — 4 check failures


1. CSpell (Spell Check) — 68 issues in 5 files

New technical terms from generated code are not in the spell-check allowlist (.vscode/cspell.json):

Relevant pipeline output
sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_operations.py:4341:37 - Unknown word (BYOS)
sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_operations.py:4506:71 - Unknown word (retriable)
sdk/ai/azure-ai-projects/azure/ai/projects/models/__init__.py:320:13 - Unknown word (MCPHTTP)
sdk/ai/azure-ai-projects/azure/ai/projects/models/_enums.py:969:11 - Unknown word (PCMU)
sdk/ai/azure-ai-projects/azure/ai/projects/models/_enums.py:971:11 - Unknown word (PCMA)
sdk/ai/azure-ai-projects/azure/ai/projects/models/_enums.py:1074:24 - Unknown word (DTMF)
sdk/ai/azure-ai-projects/azure/ai/projects/models/_models.py:24924:93 - Unknown word (BYOS)
sdk/ai/azure-ai-projects/azure/ai/projects/models/_models.py:13636:60 - Unknown word (Pcma)
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_operations.py:8432:71 - Unknown word (retriable)
CSpell: Files checked: 14, skipped: 1, Issues found: 68 in 5 files.
Spelling errors detected. To correct false positives or learn about spell checking see: https://aka.ms/azsdk/engsys/spellcheck

Unknown words: BYOS, retriable, MCPHTTP, PCMU, PCMA, DTMF, dtmf, Pcma, Pcmu, pcmu, pcma


2. Mypy — 12 errors in source + 2 errors in samples

Relevant pipeline output
Found 10 errors in 3 files (checked 50 source files)

samples/evaluations/sample_scheduled_evaluations.py:160: error: Too many positional arguments for "RoleAssignmentCreateParameters"  [misc]
samples/evaluations/sample_scheduled_agent_traces_evaluation_smart_filter.py:144: error: Too many positional arguments for "RoleAssignmentCreateParameters"  [misc]
Found 2 errors in 2 files (checked 207 source files)

mypy check completed with exit code 1
=== SUMMARY ===
/mnt/vss/_work/1/s/sdk/ai/azure-ai-projects  mypy  FAIL(1)  29.06s

The two sample files call RoleAssignmentCreateParameters with too many positional arguments, likely due to an API change in azure-mgmt-authorization.


3. Pyright — 12 errors in generated code

Relevant pipeline output
azure/ai/projects/aio/operations/_operations.py:319:15 - error: "generate_agent" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
azure/ai/projects/aio/operations/_operations.py:338:43 - error: Variable not allowed in type expression (reportInvalidTypeForm)
azure/ai/projects/models/_models.py:17704:15 - error: Variable not allowed in type expression (reportInvalidTypeForm)
azure/ai/projects/models/_models.py:25164:5 - error: "id" overrides symbol of same name in class "OmitPropertiesRealtimeResponse"
  Override type "str" is not the same as base type "str | None" (reportIncompatibleVariableOverride)
azure/ai/projects/operations/_operations.py:4250:9 - error: "generate_agent" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
12 errors, 0 warnings, 0 informations
pyright check completed with exit code 1

4. Sphinx — 4 warnings treated as errors

Relevant pipeline output
build finished with problems, 4 warnings (with warnings treated as errors).
sphinx-build failed for path .venv_sphinx/.staging/unzipped/docgen exited with error 1
sphinx check completed with exit code 1
=== SUMMARY ===
/mnt/vss/_work/1/s/sdk/ai/azure-ai-projects  sphinx  FAIL(1)  163.06s

Recommended next steps

  1. CSpell: Add the unknown technical terms (BYOS, retriable, MCPHTTP, PCMU, PCMA, DTMF, dtmf, Pcma, Pcmu, pcmu, pcma) to .vscode/cspell.json under the words allowlist.
  2. Mypy samples: Fix RoleAssignmentCreateParameters calls in samples/evaluations/sample_scheduled_evaluations.py:160 and samples/evaluations/sample_scheduled_agent_traces_evaluation_smart_filter.py:144 to use keyword arguments instead of positional arguments.
  3. Pyright + Sphinx: The generated files (_operations.py, _models.py) have type-expression and overload issues. These likely require a TypeSpec regeneration or handcrafted fixes in the generated code. Check if a new SDK generation resolves these.
  4. See https://aka.ms/ci-fix

Automated fix: Requested

Generated by Pipeline Analysis Next Steps · 76.5 AIC · ⌖ 11.3 AIC · ⊞ 6K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant