live-test-powershell: read public PR head with github.token#44
Open
a0x1ab wants to merge 1 commit into
Open
Conversation
…assic-PAT policy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up smoke-test fix for the PowerShell live-test workflow.
Finding from smoke test (dispatch against
main, PR Azure/azure-powershell#29780): the SDK + Key Vault + BAMI OIDC logins all pass (credential reuse works). The run failed at Resolve PR head SHA because the bot PAT (azclibot-pat) is a classic PAT with >8-day lifetime, which the Microsoft Open Source enterprise now forbids forgh api. This affects the existinglive-test.ymlidentically.Fix: read the (public) azure-powershell PR head via the ambient
github.tokeninstead of the bot PAT. The bot PAT is only needed for the cross-repo comment write.Note: OIDC federated creds are scoped to
refs/heads/main, so this must be onmainto be validated end-to-end via dispatch. The comment-post step still needs the PAT rotated to fine-grained/≤8-day to post back to azure-powershell PRs.