NF: add string and slice slicing of AxesManager#68
Open
matthew-brett wants to merge 1 commit intoBIDS:masterfrom
Open
NF: add string and slice slicing of AxesManager#68matthew-brett wants to merge 1 commit intoBIDS:masterfrom
matthew-brett wants to merge 1 commit intoBIDS:masterfrom
Conversation
After this PR, you can do the following two slicing operations, that
previously raised errors:
>>> da = DataArray(np.ones((2, 3, 4)), 'abc')
>>> da.axes['b']
Axis(name='b', index=1, labels=None)
>>> da.axes[1:]
(Axis(name='b', index=1, labels=None), Axis(name='c', index=2,
labels=None))
Note that, as currently written, these two both return an Axis:
>>> da.axes['b']
Axis(name='b', index=1, labels=None)
>>> da.axes('b')
Axis(name='b', index=1, labels=None)
Collaborator
Author
|
Thinking about it - I am ambivalent about this change. It's a bit annoying that there are now two ways to get an axis by name, and you can always to the slicing by iterating over the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR, you can do the following two slicing operations, that
previously raised errors:
Note that, as currently written, these two both return an Axis: