Proposal : First version of an ExternalUndoBufferInterface#112
Open
berdal84 wants to merge 5 commits intoBalazsJako:masterfrom
Open
Proposal : First version of an ExternalUndoBufferInterface#112berdal84 wants to merge 5 commits intoBalazsJako:masterfrom
berdal84 wants to merge 5 commits intoBalazsJako:masterfrom
Conversation
berdal84
commented
Feb 14, 2020
using public interface.
Contributor
Author
|
I just added a fix in InsertText public method to add an UndoRecord. From outside of a TextEditor I was unable to undo a text insertion. |
User must implement how to undo the UndoRecord received himself.
berdal84
commented
Feb 15, 2020
Contributor
Author
|
What do you think of my proposal @BalazsJako ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First draft version of an external undo buffer interface.
The concept is simple, this interface consists on a single method that can receive an UndoRecord& as ar gument. This method is called only if the TextEditor as an mExternalUndoRecordBuffer not null.
I had to set public a lot of your classes: UndoRecord, EditorState and the type UndoBuffer.
I choose to modify as less possible things, but I think it should be better to introduce a boolean to says is undobuffer is internal or external and then use that boolean to avoid all internal undo/redo stuff.
I don't really know why UndoRecord.Undo() takes a TextEditor pointer. Is is to avoid to store it in each Record ?
Let me know your impressions about my proposal.
Cheers