VAPI-2700 Add Endpoint Event Model and Related Enums by smoghe-bw · Pull Request #173 · Bandwidth/csharp-sdk

smoghe-bw · 2026-01-20T20:57:25Z

Created EndpointEvent class to represent events occurring on endpoints.
Introduced EndpointEventTypeEnum to define event types (DEVICE_CONNECTED, DEVICE_DISCONNECTED).
Added EndpointResponse class for handling responses related to endpoints.
Implemented EndpointStatusEnum to represent endpoint statuses (CONNECTED, DISCONNECTED).
Added EndpointTypeEnum for defining endpoint types (WEBRTC).
Created Endpoints class to encapsulate endpoint details.
Introduced ErrorResponse class for managing error responses.
Added ListEndpointsResponse class for handling lists of endpoints.
Implemented Page class for pagination support in endpoint listings.
Created SipConnectionMetadata class to manage SIP connection details.
Added SipCredentials class for handling SIP authentication credentials.

- Created EndpointEvent class to represent events occurring on endpoints. - Introduced EndpointEventTypeEnum to define event types (DEVICE_CONNECTED, DEVICE_DISCONNECTED). - Added EndpointResponse class for handling responses related to endpoints. - Implemented EndpointStatusEnum to represent endpoint statuses (CONNECTED, DISCONNECTED). - Added EndpointTypeEnum for defining endpoint types (WEBRTC). - Created Endpoints class to encapsulate endpoint details. - Introduced ErrorResponse class for managing error responses. - Added ListEndpointsResponse class for handling lists of endpoints. - Implemented Page class for pagination support in endpoint listings. - Created SipConnectionMetadata class to manage SIP connection details. - Added SipCredentials class for handling SIP authentication credentials.

bwappsec · 2026-01-20T21:06:15Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

…Enum

…mprove API client configuration

…update status code assertions

…stead of expected 400

…into brtc-sdk-2

… spec

…CreateEndpointTest

- Created tests for CreateEndpointRequestBase, CreateEndpointResponseData, CreateEndpointResponse, CreateWebRtcConnectionRequest, Device, Endpoint, and Endpoints classes. - Implemented serialization and deserialization tests for various models. - Added tests for enum values and their serialization/deserialization for DeviceStatusEnum, EndpointDirectionEnum, EndpointStatusEnum, and EndpointTypeEnum. - Included validation tests to ensure required fields throw exceptions when null. - Enhanced coverage for ListEndpointsResponse and its associated properties.

…ed variables

ckoegel · 2026-03-23T20:18:05Z

src/Bandwidth.Standard.Test/Unit/Model/CreateEndpointRequestBaseTests.cs

+        }
+
+        [Fact]
+        public void SerializationTest()


this test is essentially testing the JSON library we use, which is unnecessary, it can be removed here and in the other tests

ckoegel · 2026-03-24T14:25:43Z

src/Bandwidth.Standard.Test/Unit/Model/EndpointEventTypeEnumTests.cs

+            EndpointEventTypeEnum connected = EndpointEventTypeEnum.CONNECTED;
+            Assert.Equal(EndpointEventTypeEnum.CONNECTED, connected);
+            Assert.Equal(1, (int)connected);


the integer test isn't helpful here, and just creating an enum twice and asserting they match isnt a real test imo, these tests can be removed

ckoegel · 2026-03-24T14:29:12Z

src/Bandwidth.Standard.Test/Unit/Model/DeviceStatusEnumTests.cs

+        [Fact]
+        public void ConnectedEnumTest()
+        {
+            Assert.Equal(1, (int)DeviceStatusEnum.CONNECTED);


this and the other integer tests for the enums are unnecessary and can be removed

ckoegel · 2026-03-24T14:29:50Z

src/Bandwidth.Standard.Test/Unit/Model/DeviceStatusEnumTests.cs

+        [Fact]
+        public void ConnectedDeserializationTest()
+        {
+            DeviceStatusEnum result = JsonConvert.DeserializeObject<DeviceStatusEnum>("\"CONNECTED\"");


this is essentially testing the JsonConvert library, not testing the enum, it can be removed

ckoegel · 2026-03-24T14:33:11Z

src/Bandwidth.Standard.Test/Unit/Model/EndpointDirectionEnumTests.cs

+        [Fact]
+        public void InboundEnumTest()
+        {
+            Assert.Equal(1, (int)EndpointDirectionEnum.INBOUND);


can be removed

ckoegel · 2026-03-24T14:46:10Z

src/Bandwidth.Standard.Test/Unit/Model/EndpointStatusEnumTests.cs

+        [Fact]
+        public void ConnectedEnumTest()
+        {
+            Assert.Equal(1, (int)EndpointStatusEnum.CONNECTED);


ckoegel · 2026-03-24T14:46:51Z

src/Bandwidth.Standard.Test/Unit/Model/EndpointTypeEnumTests.cs

+        [Fact]
+        public void WebRtcEnumTest()
+        {
+            Assert.Equal(1, (int)EndpointTypeEnum.WEBRTC);


ckoegel · 2026-03-24T19:13:47Z

src/Bandwidth.Standard.Test/Smoke/EndpointsIntegrationTests.cs

+            Assert.IsType<ListEndpointsResponse>(listResponse.Data);
+            Assert.IsType<List<Link>>(listResponse.Data.Links);
+            Assert.IsType<List<Error>>(listResponse.Data.Errors);
+            Assert.IsType<List<Endpoints>>(listResponse.Data.Data);


we can assert on the first element in the list since we know we've just created one

ckoegel · 2026-03-24T19:19:03Z

src/Bandwidth.Standard.Test/Smoke/EndpointsIntegrationTests.cs

+            // List with filter
+            var filteredResponse = _api.ListEndpoints(_accountId, type: EndpointTypeEnum.WEBRTC, limit: 5);
+            Assert.IsType<List<Endpoints>>(filteredResponse.Data);
+            foreach (var endpoint in filteredResponse.Data)
+            {
+                Assert.Equal(EndpointTypeEnum.WEBRTC, endpoint.Type);
+            }


this test can be removed

ckoegel · 2026-03-24T19:20:01Z

src/Bandwidth.Standard.Test/Smoke/EndpointsIntegrationTests.cs

+            _accountId = Environment.GetEnvironmentVariable("BW_ACCOUNT_ID");
+            var clientId = Environment.GetEnvironmentVariable("BW_CLIENT_ID");
+            var clientSecret = Environment.GetEnvironmentVariable("BW_CLIENT_SECRET");


can we redo this to make it more like the client initialization in the other smoke tests, just for consistency

ckoegel · 2026-03-24T19:26:38Z

This PR is also missing some unit tests for some of the new models, make sure to generate them and add those too

ckoegel · 2026-03-26T18:07:42Z

src/Bandwidth.Standard/Model/Bxml/Verbs/Connect.cs

missing unit tests for this and the endpoint verb

- Remove JSON serialization/deserialization tests from model test files (tests the JSON library, not the model) - Remove integer value tests and JsonConvert tests from enum test files - Remove duplicate enum creation tests from EndpointEventTypeEnumTests - Standardize enum tests to use concise assertion style - Simplify smoke test list assertion to check first element - Remove filter test from smoke tests - Make smoke test client initialization consistent with other smoke tests - Add missing BXML verb tests for Connect and Endpoint - Add missing model unit tests for CreateEndpointRequest, ErrorResponse, Page, SipConnectionMetadata, and SipCredentials Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <[email protected]>

smoghe-bw changed the title ~~Add Endpoint Event Model and Related Enums~~ VAPI-2700 Add Endpoint Event Model and Related Enums Jan 20, 2026

smoghe-bw added 5 commits January 21, 2026 16:46

Add unit tests for EndpointsApi, EndpointEvent, and EndpointEventType…

13d038e

…Enum

Add integration tests for EndpointsApi with various endpoint operations

b46f46a

Refactor Endpoints integration tests to use synchronous methods and i…

6317d6f

…mprove API client configuration

Refactor endpoint creation requests to use CreateEndpointRequest and …

798b52b

…update status code assertions

Skip GenerateMessagingCodeBadRequest test due to API returning 500 in…

95a7a10

…stead of expected 400

smoghe-bw marked this pull request as ready for review January 22, 2026 19:43

smoghe-bw requested review from a team as code owners January 22, 2026 19:43

smoghe-bw and others added 13 commits January 27, 2026 10:31

Merge branch 'main' into brtc-sdk-2

8c1a50f

Add Connect and Endpoint classes to BXML verbs for call connection

93529aa

Merge remote-tracking branch 'origin/main' into brtc-sdk-2

142fdd5

Merge branch 'brtc-sdk-2' of https://github.com/Bandwidth/csharp-sdk …

672029b

…into brtc-sdk-2

Merge remote-tracking branch 'origin/main' into brtc-sdk-2

76df5a8

Fix parameter references and add beta badges for endpoints in OpenAPI…

e1e1517

… spec

Rename CreateEndpointResponseObject to CreateEndpointResponseData in …

6c10eab

…CreateEndpointTest

Remove CreateEndpointResponseObject class and documentation

04a2c5d

Merge branch 'main' into brtc-sdk-2

3b5af1e

Merge branch 'main' into brtc-sdk-2

9594484

Refactor EndpointsSmokeTests: Simplify initialization and remove unus…

194922b

…ed variables

Merge branch 'main' into brtc-sdk-2

30d9c2c

ckoegel reviewed Mar 24, 2026

View reviewed changes

ckoegel reviewed Mar 26, 2026

View reviewed changes

src/Bandwidth.Standard/Model/Bxml/Verbs/Connect.cs

Copy link

Contributor

ckoegel Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit tests for this and the endpoint verb

Merge branch 'main' into brtc-sdk-2

7052a84

Conversation

smoghe-bw commented Jan 20, 2026

Uh oh!

bwappsec commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckoegel commented Mar 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bwappsec commented Jan 20, 2026 •

edited

Loading