Open
Conversation
- Implemented Page model with pagination attributes including pageSize, totalElements, totalPages, and pageNumber. - Added SipConnectionMetadata model to encapsulate SIP connection details such as ipAddress, port, credentials, and uuiHeader. - Created SipCredentials model for managing SIP authentication with username and password fields. - Each model includes methods for JSON serialization/deserialization and validation. - Introduced support for additional undeclared properties in each model.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Updated CreateEndpointResponse to use CreateEndpointResponseData, Error, and Link classes. - Refactored EndpointResponse, ErrorResponse, and ListEndpointsResponse to replace Error1 and Link1 with Error and Link. - Added CreateEndpointResponseData class with properties and validation methods. - Improved documentation for InboundCallback, LookupResult, MachineDetectionConfiguration, MessageRequest, RbmOpenUrlEnum, RbmWebViewEnum, and StatusCallback. - Created new markdown documentation for CreateEndpointResponseData.
…into brtc-java-sdk
…plify unauthorized exception handling
ckoegel
reviewed
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Unit tests for the models look great, but like python and C#, there are models that were added to the SDK that don't have unit test files, we need to generate those and fill them in. There also is not a mock/unit test for this API, we need to add that
|
|
||
| @Test | ||
| @Order(1) | ||
| public void shouldCreateNewEndpoint() throws ApiException { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void shouldCreateNewEndpoint() throws ApiException { | |
| public void createEndpointTest() throws ApiException { |
can we make this and the other methods match most of the other smoke tests where the format is <operationId>Test
Comment on lines
+44
to
+46
| CreateWebRtcConnectionRequest endpointBody = new CreateWebRtcConnectionRequest(); | ||
| endpointBody.setType(EndpointTypeEnum.WEBRTC); | ||
| endpointBody.setDirection(EndpointDirectionEnum.BIDIRECTIONAL); |
Contributor
There was a problem hiding this comment.
we've moved towards setting the fields on initialization like in the multi-channel smoke tests
Comment on lines
+50
to
+60
| assertThat(response.getStatusCode(), is(201)); | ||
| assertThat(response.getData(), notNullValue()); | ||
| assertThat(response.getData().getData(), notNullValue()); | ||
| assertThat(response.getData().getData(), hasProperty("endpointId", is(instanceOf(String.class)))); | ||
| assertThat(response.getData().getData(), hasProperty("token", is(instanceOf(String.class)))); | ||
| assertThat(response.getData().getData(), hasProperty("type", is(EndpointTypeEnum.WEBRTC))); | ||
| assertThat(response.getData().getData(), hasProperty("status", notNullValue())); | ||
| assertThat(response.getData().getData(), hasProperty("creationTimestamp", notNullValue())); | ||
| assertThat(response.getData().getData(), hasProperty("expirationTimestamp", notNullValue())); | ||
| assertThat(response.getData().getErrors(), instanceOf(List.class)); | ||
| assertThat(response.getData().getErrors(), hasSize(0)); |
Contributor
There was a problem hiding this comment.
lets make the assertions look more like the ones in the tn lookup and multi-channel smoke tests, not using notNullValue or hasProperty
Comment on lines
+70
to
+75
| assertThat(response.getStatusCode(), is(200)); | ||
| assertThat(response.getData(), notNullValue()); | ||
| assertThat(response.getData().getData(), instanceOf(List.class)); | ||
| assertThat(response.getData().getPage(), notNullValue()); | ||
| assertThat(response.getData().getPage().getTotalElements(), notNullValue()); | ||
| assertThat(response.getData().getErrors(), instanceOf(List.class)); |
Contributor
There was a problem hiding this comment.
same as above for these and the rest of the assertions
Comment on lines
+77
to
+80
| Endpoints createdEndpoint = response.getData().getData().stream() | ||
| .filter(item -> item.getEndpointId().equals(endpointId)) | ||
| .findFirst() | ||
| .orElse(null); |
Contributor
There was a problem hiding this comment.
we dont need to do this complex logic, we can just assert the fields exist on the first element in the array
Comment on lines
+89
to
+103
| @Test | ||
| @Order(3) | ||
| public void shouldListEndpointsFilteredByType() throws ApiException { | ||
| ApiResponse<ListEndpointsResponse> response = api.listEndpointsWithHttpInfo(BW_ACCOUNT_ID, EndpointTypeEnum.WEBRTC, null, null, null); | ||
|
|
||
| assertThat(response.getStatusCode(), is(200)); | ||
| assertThat(response.getData().getData(), instanceOf(List.class)); | ||
| assertThat(response.getData().getErrors(), instanceOf(List.class)); | ||
|
|
||
| if (response.getData().getData().size() > 0) { | ||
| boolean allWebRtc = response.getData().getData().stream() | ||
| .allMatch(item -> item.getType() == EndpointTypeEnum.WEBRTC); | ||
| assertThat(allWebRtc, is(true)); | ||
| } | ||
| } |
|
|
||
| @Test | ||
| @Order(4) | ||
| public void shouldRetrieveDetailsOfSpecificEndpoint() throws ApiException { |
Contributor
There was a problem hiding this comment.
Suggested change
| public void shouldRetrieveDetailsOfSpecificEndpoint() throws ApiException { | |
| public void getEndpointTest() throws ApiException { |
Contributor
|
This is missing the BXML verbs and tests for them as well |
- Add Connect and Endpoint BXML verbs with tests, registered in Bxml and Response - Create EndpointsApi unit/mock test following existing API test patterns - Add missing model unit tests: CreateWebRtcConnectionRequest, Device, DeviceStatusEnum, ErrorResponse, Page, SipConnectionMetadata, SipCredentials - Rename smoke test methods to operationId format (createEndpointTest, etc.) - Use builder-style field initialization instead of setters - Replace notNullValue()/hasProperty() assertions with direct field assertions - Simplify list assertions to check first element directly - Remove unnecessary filter-by-type test Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <[email protected]>
Use BW_CLIENT_ID and BW_CLIENT_SECRET from environment variables instead of hardcoded fake credentials, matching the pattern used by CallsApiTest and other unit tests. The OAuth token request hits the real auth server before reaching Prism, so fake credentials cause all 5 tests to fail with invalid_client errors. Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.