Conversation
There was a problem hiding this comment.
Code Review
This pull request aims to fix the layout of the selection action bar for its inline variant. The changes correctly enable flex-wrapping and add centering to the buttons. However, I've identified one issue where the Cancel button is incorrectly configured to stretch, which contradicts the desired layout shown in the PR's "after" screenshot. My review includes a specific code suggestion to align the implementation with the visual goal.
|
Hey @neooriginal! Thanks for this webui fix. We're tidying up stale PRs — this one has been open 19 days without test or demo evidence (screenshot, video, or test results). Could you please add a screenshot or short demo showing the fix works, then reopen when ready? Happy to review once that's in place. |
|
Hey @neooriginal 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! 💜 |
|
Reopening — apologies! I missed the before/after screenshots in the description. This PR does have visual demo evidence. Sorry for the noise. |
|
Hey @neooriginal, merging this — thanks for the work. Honest note: I don't have any plans to actively maintain the web version right now. I know that's tough to hear, but I don't want to waste the community's energy on reviews that go nowhere. So I'm merging these. As a next step, it would be great if you could talk to the team about taking ownership of the Omi web version maintenance. Would love to see it move forward with a proper maintainer behind it. |
before:

after:
