Skip the log-start aura snapshot while unit auras are restricted - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a log in an active M+ (or any other content with aura restrictions) errors since 12.1:
12.1 added
RequiresUnitAuraAccessto the aura enumeration APIs, so they now throw for tainted code under restrictions instead of returning secret values, and theissecretvaluechecks inside the snapshot loop never run. The error aborts StartLog after event registration, so recording continues but the "Beginning Transcript" print never appears and StartLog returns nothing to its caller.This skips the snapshot when
C_Secrets.ShouldAurasBeSecret()returns true. The function exists since 12.0, with a fallback for classic clients that lackC_Secrets. Skipping loses nothing: the data is unobtainable in that state anyway. Verified in-game in a key (enumeration throws and the predicate is true, both in and out of combat) and in open world (enumeration works and the predicate is false).