Repository navigation
Wma/compliance - #35
Merged
Merged
Conversation
git-subtree-dir: third_party/cnpy git-subtree-split: 4e8810b1a8637695171ed346ce68f6984e585ef4
Contributor
Author
|
@BenBrock This tests compliance against the python parser I wrote. The bulk of the updates are just adding the compliance tests, and adding CI. This makes the julia tests obsolete, as we can test compliance for julia separately. I've delayed deleting julia stuff till you agree. Hypothesis found what I believe to be a few bugs in the C parser, and this PR introduces a few very small fixes to the parser, but I don't think it changes the parser outputs much, if at all. |
Contributor
|
Hi @willow-ahrens, just back from vacation—is this ready for me to review and merge? |
BenBrock
approved these changes
Sep 23, 2026
BenBrock
left a comment
BenBrock
left a comment
Contributor
There was a problem hiding this comment.
This PR removed the C++ and Julia tests, which I'm not sure was intentional. I reverted those parts of the PR. Otherwise it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds compliance tests for the C reference parser.
The test suite requires that we implement format conversion. I've asked codex to implement a conversion utility based on the strategy from the python parser, it does the standard format1->coo->qsort->format2 pipeline, even for dense arrays. It's not meant to be fast, it's only for testing.