OPSRC-505 Support for Twigcs#13
Open
JakubWegner wants to merge 14 commits intoBitBagCommerce:mainfrom
Open
Conversation
senghe
requested changes
Aug 28, 2022
Member
senghe
left a comment
senghe
left a comment
There was a problem hiding this comment.
I can't verify the business compatibility of this code, but I think a set of good PHPUnit integration tests would make me reaching the point.
| $violations = []; | ||
|
|
||
| $content = str_replace("\r", '', $tokens->getSourceContext()->getCode()); | ||
| $this->htmlUtil->stripUnnecessaryTagsAndSavePositions($content); |
Member
There was a problem hiding this comment.
the "and" in method tells us, it's not SRP friendly ;)
| $violations = []; | ||
|
|
||
| $content = str_replace("\r", '', $tokens->getSourceContext()->getCode()); | ||
| $this->htmlUtil->stripUnnecessaryTagsAndSavePositions($content); |
| $this->htmlUtil->stripUnnecessaryTagsAndSavePositions($content); | ||
|
|
||
| foreach ($this->getMultiLines($content) as $multiline) { | ||
| if ($this->htmlUtil->isInsideUnnecessaryTag($multiline['offset'][1])) { |
Member
There was a problem hiding this comment.
the HtmlUtil class is too generic for "UnnecessaryTag". What does mean the "UnnecessaryTag"?
| $this->htmlUtil = $htmlUtil; | ||
| } | ||
|
|
||
| public function check(TokenStream $tokens) |
Member
There was a problem hiding this comment.
Is there any reason of not having return types in the check method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Twigcs with custom BitBag rules