-
Notifications
You must be signed in to change notification settings - Fork 4
Restrict ULPIN generation to India using reverse geocoding #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theripper-1920
wants to merge
4
commits into
BitForge95:main
Choose a base branch
from
theripper-1920:frontend-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−142
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d705340
Restrict ULPIN generation to India using reverse geocoding
theripper-1920 090bbf6
Add Leaflet dependency and enhance ULPIN generation for India locations
theripper-1920 e2f0607
Update frontend-ui/src/components/Mapview.jsx
theripper-1920 b6bb70e
Update frontend-ui/DEPENDENCY_CHANGES.md
theripper-1920 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Frontend UI - Dependency Version Changes | ||
|
|
||
| ## Lockfile Updates (package-lock.json) | ||
|
|
||
| This PR includes the following dependency version upgrades in addition to adding Leaflet for map functionality: | ||
|
|
||
| ### Production Dependencies | ||
| - **axios**: `1.13.6` → `1.14.0` (minor version bump, backward compatible) | ||
| - **leaflet**: `^1.9.4` (newly added for map functionality) | ||
|
|
||
| ### Development Dependencies | ||
| - **vite**: `8.0.0` → `8.0.3` (patch version bump, bug fixes) | ||
| - Various Babel and build tool dependencies updated to compatible versions | ||
|
|
||
| ## Rationale | ||
|
|
||
| These version upgrades are the result of: | ||
| 1. **Leaflet addition**: A new dependency required for the land parcel map visualization feature | ||
| 2. **npm install resolution**: When adding leaflet, npm resolved dependencies to the latest patch/minor versions compatible with the `^` constraints in package.json | ||
|
|
||
| ## Compatibility Notes | ||
|
|
||
| - **axios 1.14.0**: Minor version bump; compatibility with existing API calls is expected per semver, but should be confirmed against the upstream changelog/release notes | ||
| - **vite 8.0.3**: Patch release with bug fixes; no breaking changes are expected per semver, subject to upstream release notes | ||
| - All upgrades remain within the caret (`^`) version constraints specified in package.json, though runtime compatibility should still be validated against upstream release documentation | ||
|
|
||
| ## Recommendation | ||
|
|
||
| If stricter version pinning is desired for production stability, consider updating package.json to use exact versions (e.g., `"vite": "8.0.3"` instead of `"vite": "^8.0.0"`). | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.