refactor(sdk-core): change BaseTransaction.id return type to string |… #8111
+118
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcovar
force-pushed
the
BTC-0-base-transaction-id-fix
branch
3 times, most recently
from
c303187 to
462e65a
Compare
… undefined Update BaseTransaction.id getter return type from string to string | undefined to accurately reflect that transaction IDs may not be available before signing/serialization. Propagate the type change to all downstream coin modules: - sdk-coin-ada: update explainTransaction return type and test assertions - sdk-coin-apt: update TxData.id type - sdk-coin-dot: update test assertions - sdk-coin-flrp: update test assertions - sdk-coin-near: update test assertions - sdk-coin-sui: update Transaction<T>.id getter return type - sdk-coin-ton: update TxData.id and local ITransactionExplanation.id types - sdk-coin-vet: update VetTransactionData.id type and test assertions BTC-0 TICKET: BTC-0
lcovar
force-pushed
the
BTC-0-base-transaction-id-fix
branch
from
462e65a to
ce05dcf
Compare
dpkjnr
reviewed
Feb 12, 2026
Contributor
dpkjnr
left a comment
dpkjnr
left a comment
There was a problem hiding this comment.
looks like a breaking change, please add a breaking change footer in the commit message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… undefined
The base class getter previously returned
stringvia an unsafe cast, but_idisstring | undefined. This makes the type honest and updates all coin implementations to returnundefinedinstead of sentinel strings like 'UNAVAILABLE' when no transaction ID is available.Changes:
Ticket: BTC-2926