fix(sdk-coin-flrp): update fromAddresses in delegator tx#8179
Merged
joshisakshi merged 1 commit intomasterfrom Feb 24, 2026
Merged
fix(sdk-coin-flrp): update fromAddresses in delegator tx#8179joshisakshi merged 1 commit intomasterfrom
joshisakshi merged 1 commit intomasterfrom
Conversation
joshisakshi
changed the title
Gautam2305
reviewed
Feb 23, 2026
modules/sdk-coin-flrp/src/lib/permissionlessDelegatorTxBuilder.ts
Outdated
Show resolved
Hide resolved
Gautam2305
reviewed
Feb 24, 2026
modules/sdk-coin-flrp/src/lib/permissionlessDelegatorTxBuilder.ts
Outdated
Show resolved
Hide resolved
modules/sdk-coin-flrp/src/lib/permissionlessDelegatorTxBuilder.ts
Outdated
Show resolved
Hide resolved
…gation tx TICKET: SC-5648 - Change fromAddressesBytes from [userAddress] to sorted _fromAddresses - Sort fromAddressesBytes to match sorted UTXO addresses - Fixes 'No addresses match UTXO owners' error in HSM firmware tests - Clarify comments about reward distribution - Fix output threshold for multisig wallets (apply threshold correction) - Add comprehensive test coverage - Document key convention for delegation tx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: SC-5648
Summary:
Change fromAddressesBytes from [userAddress] to sorted _fromAddresses
Sort fromAddressesBytes before passing to FlareJS to match sorted UTXO addresses
Fixes 'No addresses match UTXO owners' error in HSM firmware tests
Clarify comments about reward distribution (determined by stake output addresses, not rewardAddresses parameter)"
Change output threshold
Add comprehensive test coverage (33 tests)