fix(ada): providing unsigned sweep support for WRW#8248
Open
fix(ada): providing unsigned sweep support for WRW#8248
Conversation
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
from
6269f8c to
2321317
Compare
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Ranjna-G
reviewed
Mar 23, 2026
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
2 times, most recently
from
9a36a38 to
bb7e4f5
Compare
Ranjna-G
reviewed
Mar 23, 2026
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
from
bb7e4f5 to
8035b13
Compare
Ranjna-G
reviewed
Mar 23, 2026
modules/sdk-coin-ada/src/ada.ts
Outdated
| address: o.address, | ||
| valueString: o.amount, | ||
| coinName: walletCoin, | ||
| ...(txOutputs[i]?.multiAssets && { assetList }), |
Contributor
There was a problem hiding this comment.
Why are we checking for multiAssets and including the input assetList? We should be parsing the outputs.multiAssets and adding it here
Ranjna-G
reviewed
Mar 23, 2026
modules/sdk-coin-ada/src/ada.ts
Outdated
| const parsedTx = await this.parseTransaction({ txPrebuild: transactionPrebuild }); | ||
| const walletCoin = this.getChain(); | ||
| const output = (parsedTx.outputs as ITransactionRecipient)[0]; | ||
| const txOutputs = unsignedTransaction.toJson().outputs; |
Contributor
There was a problem hiding this comment.
Can we try to add the parsing logic for tokens in the explainTransaction itself?
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
from
8035b13 to
8e74410
Compare
Ranjna-G
reviewed
Mar 23, 2026
|
|
||
| private static parseMultiAssets(multiAssets: CardanoWasm.MultiAsset | Asset | undefined): Asset[] | undefined { | ||
| if (!multiAssets) return undefined; | ||
| if (!(multiAssets instanceof CardanoWasm.MultiAsset)) { |
Contributor
There was a problem hiding this comment.
When will this if case be executed?
Ranjna-G
reviewed
Mar 23, 2026
| /** @inheritdoc */ | ||
| explainTransaction(): { | ||
| outputs: { amount: string; address: string }[]; | ||
| outputs: { amount: string; address: string; assetList?: Asset[] }[]; |
Contributor
There was a problem hiding this comment.
Shall we please use the same key name multiAssets after parsing as well just to be consistent
Ranjna-G
reviewed
Mar 23, 2026
modules/sdk-coin-ada/src/ada.ts
Outdated
| valueString: output.amount, | ||
| coinName: walletCoin, | ||
| value: new BigNumber(output.amount as string).toNumber(), | ||
| ...(inputAssetList.length > 0 && { assetList: inputAssetList }), |
Contributor
There was a problem hiding this comment.
Please fix the key here as well
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
from
8e74410 to
f8fea96
Compare
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
2 times, most recently
from
5e0aef9 to
946357c
Compare
Ticket: CSHLD-134 Made-with: Cursor
dgm003
force-pushed
the
fix/ada-unsigned-sweep-CSHLD-134
branch
from
946357c to
70c8834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-134
Description
Extends the ADA unsigned sweep (cold wallet recovery) flow to correctly handle token-holding wallets.
Two gaps existed in the unsigned sweep path:
parsedTx.outputs[0], so token transactions with 2 outputs were brokenChanges:
extractTokenTransfers()helper that convertsCardanoWasm.MultiAssetinto a flat '{ policyId, assetName, quantity }' array. Updated 'explainTransaction()' return type and output mapping to include 'tokenTransfers?' per output.recover()unsigned sweep path to map over all 'parsedTx.outputs' instead of hardcoding only 'outputs[0]', with 'tokenTransfers' passed through.tokenTransferspopulated inexplainTransaction().Issue Number
CSHLD-134
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Ran npx mocha test file