fix: bump brace-expansion and nx to clear ReDoS advisory - #9361
Merged
Conversation
prajwalu142
force-pushed
the
bumpVulnPackages
branch
from
July 27, 2026 10:44
919f4ea to
04dd9e0
Compare
## Problem osv-scanner flagged brace-expansion@1.1.16 and @2.1.2 (GHSA-mh99-v99m-4gvg, CVSS 7.5 ReDoS) as blocking, failing the release gate (>= CVSS 7.0). The upstream fix only ships in brace-expansion@5.0.8, which changed its export shape in a way that broke nx's bundled minimatch usage. ## Goal Resolve to the patched brace-expansion release with a clean build, no compatibility shims. ## Fix - Pin `brace-expansion` to `5.0.8` via root resolutions/overrides. - Bump `nx` (lerna's project-graph dependency) to `22.7.7`, whose own minimatch dependency already speaks brace-expansion's new export API. Note: lerna's own nested `minimatch@3.0.5` still calls brace-expansion in the old callable style, which is technically mismatched with 5.0.8. It isn't triggered in practice because this repo's lerna/nx config never uses brace-syntax (`{a,b}`) glob patterns. ## Testing Ran a full clean `yarn install` (postinstall + `lerna run build --stream` across all 112 packages succeeds) and re-ran osv-scanner locally with the same config CI uses -- brace-expansion no longer appears in the results and no advisory group is at or above CVSS 7.0. TICKET: CSHLD-1290 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
prajwalu142
force-pushed
the
bumpVulnPackages
branch
from
July 28, 2026 04:55
04dd9e0 to
fd24dde
Compare
diksha190
approved these changes
Jul 28, 2026
diksha190
left a comment
There was a problem hiding this comment.
Approved.
Exception type: CVE fix — GHSA-mh99-v99m-4gvg / CVE-2026-14257 (brace-expansion DoS via unbounded expansion, CVSS 7.5 High). Qualifies under the Dependency Exception Policy (severity ≥ 7.0).
Review:
- Fixed version confirmed: brace-expansion@5.0.8 (published ~4-5 days ago, hence the cooldown block)
- Socket: Deep score 81 (≥70 threshold), no high/critical alerts
- Aikido SafeChain:
npm install brace-expansion@5.0.8completed without being blocked - Package: brace-expansion@5.0.8. No conditions.
prajwalu142
marked this pull request as ready for review
July 28, 2026 08:14
veetragjain
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
osv-scanner flagged brace-expansion@1.1.16 and @2.1.2 (GHSA-mh99-v99m-4gvg, CVSS 7.5 ReDoS) as blocking, failing the release gate (>= CVSS 7.0). The upstream fix only ships in brace-expansion@5.0.8, which changed its export shape in a way that broke nx's bundled minimatch usage.
Goal
Resolve to the patched brace-expansion release with a clean build, no compatibility shims.
Fix
brace-expansionto5.0.8via root resolutions/overrides.nx(lerna's project-graph dependency) to22.7.7, whose own minimatch dependency already speaks brace-expansion's new export API.Note: lerna's own nested
minimatch@3.0.5still calls brace-expansion in the old callable style, which is technically mismatched with 5.0.8. It isn't triggered in practice because this repo's lerna/nx config never uses brace-syntax ({a,b}) glob patterns.Testing
Ran a full clean
yarn install(postinstall +lerna run build --streamacross all 112 packages succeeds) and re-ran osv-scanner locally with the same config CI uses -- brace-expansion no longer appears in the results and no advisory group is at or above CVSS 7.0.