lowercase all the strings#426
Open
Alessandro-Barbieri wants to merge 8 commits intoBreakBB:masterfrom
Open
Conversation
Contributor
Author
|
do you prefer a huge migration or a profile reset? |
Contributor
Author
|
I opted for the profile reset because the migration looked ridiculously long |
BreakBB
reviewed
Mar 2, 2026
| type = "toggle", | ||
| order = 2, | ||
| name = function() return i18n("Off Hand") end, | ||
| hidden = function() return not CanDualWield() end, |
Owner
There was a problem hiding this comment.
This line got lost and changing it should be a separate PR imo.
| type = "toggle", | ||
| order = 0, | ||
| name = function() return i18n("Show Defense Stats") end, | ||
| name = function() return i18n("Show defense stats") end, |
Owner
There was a problem hiding this comment.
I don't think stat names should be lower case. So I'd prefer "Defense" over "defense" and "Mana" over "mana" and "Shadow Damage" over "Shadow damage".
The default UI is also using capitalized words like "Crit Chance".
I am okay with using "stats" and "values". For me "Hit Rating" is also a stat name, so I don't think it should be lower case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.