Replace theme toggle icons with Tabler icons#52
Merged
Conversation
- Install @tabler/icons-react in docs package - Replace unicode sun/moon characters with IconSun/IconMoon from tabler - Maintain same button sizing, styling, and toggle logic
✅ Deploy Preview for agent-native-fw ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
builder-io-integration
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the Unicode character-based dark/light mode toggle icons in the docs site with proper Tabler icons (
IconSunandIconMoon).Problem
The docs site's theme toggle was using raw Unicode characters (☀ and ☾) for the light and dark mode icons, which were visually inconsistent with the rest of the UI that uses Tabler icons.
Solution
Added the
@tabler/icons-reactpackage to the docs site and swapped the Unicode characters inThemeToggle.tsxwith theIconSunandIconMoonTabler icon components.Key Changes
@tabler/icons-react@^3.40.0as a dependency inpackages/docs/package.jsonIconSunandIconMoonfrom@tabler/icons-reactinThemeToggle.tsx\u2600) and moon (\u263E) characters with<IconSun size={16} stroke={1.5} />and<IconMoon size={16} stroke={1.5} />respectivelypnpm-lock.yamlto reflect the new dependencyTo clone this PR locally use the Github CLI with command
gh pr checkout 52You can tag me at @BuilderIO for anything you want me to fix or change