Fix clipped tab glow effect on docs homepage#55
Merged
Conversation
✅ Deploy Preview for agent-native-fw ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
builder-io-integration
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the focus/glow effect on tabs in the "Agents and UIs — fully connected" section of the docs homepage, which was being clipped by the parent container's
overflow: auto.Problem
When a tab in the
BidirectionalTabscomponent received focus or was selected, its glow/focus ring was visually cut off because the parent container usedoverflow-x-autowithout any padding to accommodate the overflow of the effect. This made the UI look broken and the focus indicator was not fully visible.Solution
Added minimal
px-1 py-1padding to the tab container on mobile to give the glow effect room to render, and setmd:overflow-visible md:p-0on larger screens to restore the original layout behavior — preserving alignment and scroll functionality.Key Changes
px-1 py-1padding to the tab list container so the focus/glow ring is not clipped on mobile/horizontal scroll layoutsmd:overflow-visible md:p-0to reset overflow and padding on medium+ screens, keeping the desktop layout unchangedTo clone this PR locally use the Github CLI with command
gh pr checkout 55You can tag me at @BuilderIO for anything you want me to fix or change