Add LDAP CRL download support - #624
Open
Roytak wants to merge 1 commit into
Open
Conversation
Restrict allowed CURL protocols to HTTP(S) and, if supported by libcurl, LDAP(S) to prevent SSRF via malicious CRL distribution point URIs. Add native LDAP CRL download support by fetching the LDIF response via CURL and parsing it to extract the base64-encoded CRL. The LDIF parser handles curl's tab-indented output, folded continuation lines and CRLF/LF line endings. Only known CRL attribute names (certificateRevocationList, authorityRevocationList, deltaRevocationList, optionally with ;binary per RFC 4523) are accepted, instead of any binary attribute. URL scheme dispatch is case-insensitive per RFC 3986. Fix nc_base64_decode_wrap (OpenSSL) to strip base64 padding from EVP_DecodeBlock's return value, matching the documented contract and the mbedTLS backend. Fixes #604
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add native LDAP CRL download support by fetching the LDIF response via CURL and parsing it to extract the base64-encoded CRL. Also restrict allowed CURL protocols to HTTP(s) and, if supported by libcurl, LDAP(s) to prevent SSRF via malicious CRL distribution point URIs.
Fixes #604