You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add daily global_stats counters for apps created, first-day CLI onboarding builds, and first-day manual builds.
Tag CLI native build requests as manual or cli_onboarding and normalize missing/unknown sources server-side.
Add an admin dashboard multi-line chart for the saved-by-day app creation/build onboarding metrics.
Screenshot
Validation
bun lint
bun lint:backend
bun typecheck
bun run cli:check
bun test tests/admin-stats.test.ts
bun test ./test/prescan/request-gate.test.ts from cli/
bun run supabase:db:reset
bunx supabase db lint --local from .context/supabase-worktrees/c85d6572 (exits 0 with existing warnings)
Captured the admin dashboard change as docs/pr-assets/admin-app-build-onboarding-chart.webp
Note
Medium Risk
Touches app creation paths, a DB migration/trigger, and daily global-stats aggregation; incorrect cohort logic would skew admin metrics but not core auth or billing.
Overview
Adds onboarding provenance on apps (created_from_onboarding, onboarding_completed_at via trigger when need_onboarding flips off) plus daily global_stats counters for apps created and first-day build activity (>2 succeeded builds in 24h, split CLI-onboarding vs manual).
Ingestion: CLI add sets created_from_onboarding for onboarding creates (with schema-missing fallback); public app create mirrors need_onboarding into that flag. Aggregation:logsnag_insights writes cohort metrics to the prior UTC day once the 24h window can complete; admin trend API exposes them with app_build_onboarding_finalized when the next day’s core shard exists.
UI: New admin multi-line chart and i18n labels; apps list normalizes onboarding fields from RPC rows. Migration redefines get_org_apps_with_last_upload with an explicit column list (no apps.*). CI concurrency uses github.head_ref for PRs. Tests cover summarization, trend fields, and admin stats.
Reviewed by Cursor Bugbot for commit 30eae79. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Added onboarding provenance tracking for apps, including creation source and completion time.
Added admin dashboard metrics and charts for apps created and first-day CLI or manual builds.
Added localized labels for the new onboarding metrics.
Bug Fixes
Improved app icon loading across different app data sources.
Added compatibility fallback when onboarding fields are unavailable.
Tests
Added coverage for onboarding metrics and admin statistics.
Adds onboarding provenance fields and daily CLI/manual build metrics, persists and aggregates them, exposes them through admin stats, and renders a new admin dashboard chart. App icon loading now supports RPC rows with missing onboarding fields, and CLI creation retries against older schemas.
Changes
App Build Onboarding Metrics
Layer / File(s)
Summary
Schema and typed contracts read_replicate/schema_replicate.*, supabase/functions/_backend/utils/postgres_schema.ts, */types/supabase.types.ts
Adds app onboarding columns, an app creation index, and corresponding database and RPC type fields.
No successful run was found on main (774b466) during the generation of this report, so c4499f9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot remained pending after the 8-minute polling window, so automated review is incomplete and I am not approving. Human review is needed for the migration, backend trigger, and admin dashboard changes.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/types/supabase.types.ts (1)
321-332: 🗄️ Data Integrity & Integration | 🟡 Minor
Update TypeScript RPC return types to reflect actual column availability.
The new created_from_onboarding and onboarding_completed_at columns are missing from the TypeScript type definitions for both RPC functions:
get_accessible_apps_for_apikey_v2 (line 3596): Returns full apps row at SQL level but TypeScript types omit the new fields, causing type-SQL mismatch.
get_org_apps_with_last_upload (line 3824): Intentionally excludes these fields (per SQL comment: "stable apps list contract"), so TypeScript correctly omits them—but this is by design.
The consumer code in src/pages/apps.vue:42-43 works around this with fallback logic ('created_from_onboarding' in app), but relying on runtime field presence is fragile. Regenerate the TypeScript types to match the SQL schema.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/types/supabase.types.ts` around lines 321 - 332, The TypeScript type
definitions in the Supabase types file for the RPC functions
`get_accessible_apps_for_apikey_v2` and `get_org_apps_with_last_upload` are out
of sync with the actual SQL schema. The `get_accessible_apps_for_apikey_v2`
function should include the `created_from_onboarding` and
`onboarding_completed_at` fields since it returns the full apps row at the SQL
level, while `get_org_apps_with_last_upload` should continue to exclude these
fields as per its design contract for a stable API. Regenerate the TypeScript
type definitions from the Supabase schema to ensure they accurately reflect what
each RPC function returns, eliminating the need for runtime field presence
checks in consumer code like `src/pages/apps.vue`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/types/supabase.types.ts`:
- Around line 321-332: The TypeScript type definitions in the Supabase types
file for the RPC functions `get_accessible_apps_for_apikey_v2` and
`get_org_apps_with_last_upload` are out of sync with the actual SQL schema. The
`get_accessible_apps_for_apikey_v2` function should include the
`created_from_onboarding` and `onboarding_completed_at` fields since it returns
the full apps row at the SQL level, while `get_org_apps_with_last_upload` should
continue to exclude these fields as per its design contract for a stable API.
Regenerate the TypeScript type definitions from the Supabase schema to ensure
they accurately reflect what each RPC function returns, eliminating the need for
runtime field presence checks in consumer code like `src/pages/apps.vue`.
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f35cf478-0df7-4267-872c-cdec0940988a
📥 Commits
Reviewing files that changed from the base of the PR and between 647bf87 and 09f48a1.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot is still pending after the 8-minute polling window and no Bugbot review comment was posted, so I am not approving without that automated signal. Human review is needed for the migration, backend metrics pipeline, and admin dashboard changes; WcaleNieWolny is already requested and I also requested Dalanir.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped status and no Bugbot review comment was posted, so I am not approving without that automated signal. Human review is still needed for the migration, backend metrics pipeline, and admin dashboard changes; WcaleNieWolny and Dalanir are already requested.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check and reported 2 unresolved findings (including one high-severity metrics timing issue), so I am not approving. WcaleNieWolny and Dalanir are already requested for human review of the migration, backend metrics pipeline, and admin dashboard changes.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@supabase/functions/_backend/triggers/logsnag_insights.ts`:
- Around line 1351-1392: The snapshot timing issue occurs because
getAppBuildOnboardingMetrics is being called too early in the day (01:01 UTC) to
capture the full 24-hour observation windows for apps created near the end of
the previous day. Find where getAppBuildOnboardingMetrics is invoked in the
snapshot recording workflow and delay the execution until after 23:59 UTC to
ensure all apps created the previous day have completed their full 24-hour build
observation window before the metric is recorded.
In `@supabase/migrations/20260623144909_admin_app_build_onboarding_metrics.sql`:
- Around line 48-52: The two CREATE INDEX statements for idx_apps_created_at and
idx_build_requests_app_created_at are missing the CONCURRENTLY keyword, which
will cause write locks on these tables during the migration. Add the
CONCURRENTLY keyword to both CREATE INDEX IF NOT EXISTS statements so that the
indexes are built without blocking concurrent write operations on the
public.apps and public.build_requests tables.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 037135c6-e2bc-4a1f-87b2-7c4102af84f8
📥 Commits
Reviewing files that changed from the base of the PR and between 09f48a1 and 22c3dc0.
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Use concurrent index creation to avoid deploy-time write blocking.
Line 48 and Line 51 create indexes without CONCURRENTLY. On large tables, this can block writes for the migration duration and degrade API availability. Move these to a dedicated migration that builds indexes concurrently.
Suggested change
-CREATE INDEX IF NOT EXISTS idx_apps_created_at-ON public.apps (created_at);--CREATE INDEX IF NOT EXISTS idx_build_requests_app_created_at-ON public.build_requests (app_id, created_at);+-- Run in a dedicated migration that supports non-transactional statements+CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_apps_created_at+ON public.apps (created_at);++CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_build_requests_app_created_at+ON public.build_requests (app_id, created_at);
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@supabase/migrations/20260623144909_admin_app_build_onboarding_metrics.sql`
around lines 48 - 52, The two CREATE INDEX statements for idx_apps_created_at
and idx_build_requests_app_created_at are missing the CONCURRENTLY keyword,
which will cause write locks on these tables during the migration. Add the
CONCURRENTLY keyword to both CREATE INDEX IF NOT EXISTS statements so that the
indexes are built without blocking concurrent write operations on the
public.apps and public.build_requests tables.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync, and the prior Bugbot review still has unresolved findings, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync, and the prior Bugbot review still has 4 unresolved findings (including high severity), so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync (usage limit reached), and the prior Bugbot review still has unresolved findings, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync (usage limit reached), and the prior Bugbot review still has 5 unresolved findings, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync, and the prior Bugbot review still has unresolved findings, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/tests.yml:
- Line 4: Update the workflow concurrency group expression to use
github.event.pull_request.number for pull_request events, while retaining the
SHA-based key for workflow_call and the existing branch/ref fallback for other
events, so unrelated PR runs cannot cancel each other.
In `@messages/en.json`:
- Line 1210: Remove the duplicate "events" key from messages/en.json, preferably
the later definition, while retaining the established earlier entry so the JSON
contains only one events property.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0a532249-e4c4-4ef5-9b9b-61e16ebd2a5b
📥 Commits
Reviewing files that changed from the base of the PR and between 22c3dc0 and f3f2dff.
The reason will be displayed to describe this comment to others. Learn more.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/tests.yml:
- Line 4: Update the workflow concurrency group expression to use
github.event.pull_request.number for pull_request events, while retaining the
SHA-based key for workflow_call and the existing branch/ref fallback for other
events, so unrelated PR runs cannot cancel each other.
In `@messages/en.json`:
- Line 1210: Remove the duplicate "events" key from messages/en.json, preferably
the later definition, while retaining the established earlier entry so the JSON
contains only one events property.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0a532249-e4c4-4ef5-9b9b-61e16ebd2a5b
📥 Commits
Reviewing files that changed from the base of the PR and between 22c3dc0 and f3f2dff.
Keep PR runs isolated in the concurrency key..github/workflows/tests.yml:4 uses only the branch name for pull_request and push runs, so two PRs from different forks with the same branch name—or a push and its PR check on the same branch—can cancel each other when cancel-in-progress: true is set. Use github.event.pull_request.number for PR events and keep the SHA-based key for workflow_call.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/tests.yml at line 4, Update the workflow concurrency group
expression to use github.event.pull_request.number for pull_request events,
while retaining the SHA-based key for workflow_call and the existing branch/ref
fallback for other events, so unrelated PR runs cannot cancel each other.
"events" is defined at Line 1210 and again at Line 2492. Biome reports this duplicate key; keep only one definition so linting and JSON parsing remain deterministic.
Proposed fix
- "events": "Events",
Remove either duplicate definition, preferably the later one if the earlier key is already established.
Also applies to: 2492-2492
🧰 Tools🪛 Biome (2.5.1)
[error] 1210-1210: The key events was already declared.
(lint/suspicious/noDuplicateObjectKeys)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@messages/en.json` at line 1210, Remove the duplicate "events" key from
messages/en.json, preferably the later definition, while retaining the
established earlier entry so the JSON contains only one events property.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync (usage limit reached) and did not post a fresh review for the current commit, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync (usage limit reached), so automated review is incomplete and I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Risk: high. Cursor Bugbot finished with a skipped check on the latest sync (usage limit reached), so automated review is incomplete and I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot finished with a skipped check on the latest sync and did not post a fresh review for the current commit, so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riderx
force-pushed
the
codex/admin-app-build-onboarding-metrics
branch
from
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
global_statscounters for apps created, first-day CLI onboarding builds, and first-day manual builds.manualorcli_onboardingand normalize missing/unknown sources server-side.Screenshot
Validation
bun lintbun lint:backendbun typecheckbun run cli:checkbun test tests/admin-stats.test.tsbun test ./test/prescan/request-gate.test.tsfromcli/bun run supabase:db:resetbunx supabase db lint --localfrom.context/supabase-worktrees/c85d6572(exits 0 with existing warnings)docs/pr-assets/admin-app-build-onboarding-chart.webpNote
Medium Risk
Touches app creation paths, a DB migration/trigger, and daily global-stats aggregation; incorrect cohort logic would skew admin metrics but not core auth or billing.
Overview
Adds onboarding provenance on
apps(created_from_onboarding,onboarding_completed_atvia trigger whenneed_onboardingflips off) plus dailyglobal_statscounters for apps created and first-day build activity (>2 succeeded builds in 24h, split CLI-onboarding vs manual).Ingestion: CLI
addsetscreated_from_onboardingfor onboarding creates (with schema-missing fallback); public app create mirrorsneed_onboardinginto that flag. Aggregation:logsnag_insightswrites cohort metrics to the prior UTC day once the 24h window can complete; admin trend API exposes them withapp_build_onboarding_finalizedwhen the next day’s core shard exists.UI: New admin multi-line chart and i18n labels; apps list normalizes onboarding fields from RPC rows. Migration redefines
get_org_apps_with_last_uploadwith an explicit column list (noapps.*). CI concurrency usesgithub.head_reffor PRs. Tests cover summarization, trend fields, and admin stats.Reviewed by Cursor Bugbot for commit 30eae79. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Bug Fixes
Tests