feat(signposting): add signposting service#873
Merged
futa-ikeda merged 1 commit intoCenterForOpenScience:feature/fair-signpostingfrom Feb 5, 2026
Merged
Conversation
nsemets
reviewed
Feb 4, 2026
nsemets
reviewed
Feb 4, 2026
futa-ikeda
force-pushed
the
feature/signposting-service
branch
from
5feb57e to
33db68c
Compare
Contributor
Author
|
Ok, I have moved the constants I still don't like how the test is written, particularly the repetitive lines like Not sure if you have any advise there, or if you think the test is fine as it is. |
nsemets
reviewed
Feb 5, 2026
nsemets
reviewed
Feb 5, 2026
futa-ikeda
force-pushed
the
feature/signposting-service
branch
from
33db68c to
ef162fe
Compare
nsemets
approved these changes
Feb 5, 2026
futa-ikeda
merged commit 01f5a10
into
CenterForOpenScience:feature/fair-signposting
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
signpostingserviceNote: This service by itself won't do anything. In the page that needs signposting, one should call
SignpostingService.addSignposting(guid);to add signposting links to the link response header and<link>tags to the<head>Screenshot(s)
npm run serve:ssr:osf:curl -I <url>to get the response headers. Note the presence of thelinkheader herecurl <url>to get the returned HTML doc (in this case saving it to a text file for illustrative purposes). Not the presence of<link rel="linkset">hereSide Effects
QA Notes