-
Notifications
You must be signed in to change notification settings - Fork 354
[ENG-9727] unable to create new version of a preprint when registration field has content #11492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkovalua
wants to merge
37
commits into
CenterForOpenScience:feature/pbs-25-25
Choose a base branch
from
mkovalua:fix/ENG-9727
base: feature/pbs-25-25
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENG-9727] unable to create new version of a preprint when registration field has content #11492
mkovalua
wants to merge
37
commits into
CenterForOpenScience:feature/pbs-25-25
from
mkovalua:fix/ENG-9727
+3,640
−2,604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ojects, Registrations and Preprints tabs (CenterForOpenScience#11276) * display only institution-specific user metrics reports * add missing exlude statement
* Update font-awesome * Update font-awesome import * Update CSS * Update footer * WIP nav and base mako * Update to styling for main content background * Update Orcid login page * Update leftnav links and styling; Add proper icons * Move maintenance banner to a more appropriate place * Remove old navbar * Appease jshint * Rework external_login_email_get&post without push status message --------- Co-authored-by: Longze Chen <[email protected]>
…NG-9127 [ENG-9127] Contributor page of components should offer option to import contributors from parent project.
…et Password” link opens a blank page (CenterForOpenScience#11367) * Add claim user api endpoint * Update ConfirmClaimUser endpoint to use 'guid' instead of 'pid' in payload and URL
* Add a new page for pending preprint moderation * Add template for pending moderation * Remove new flask view
…ce/develop Merge develop into `feature/pbs-25-21`
* fix test * fix other serializers * linting
…or unversioned URL (CenterForOpenScience#11315) * fix versioned guids resolving to the last published version instead of last version number * fix migration job * handle initial review_state in fix_versioned_guids job * adjusted tests to pass with new guid resolve strategy * handle the case for withdrawn/rejected preprints * fix missing.all()
…min (CenterForOpenScience#11278) * added edit contributors button and basic table * added edit pop-up data display * moved remove functionality to a new edit contributors pop-up * added contributors removal and permissions update * added an ability to add a new contributor + html improvements * removed redundant code * fixed permissions * fixed test * added an ability to add multiple contributors + handle some edge cases * removed redundant conversion * fix test (CenterForOpenScience#11394) * fix test * fix other serializers * linting * added edit contributors button and basic table * added edit pop-up data display * moved remove functionality to a new edit contributors pop-up * added contributors removal and permissions update * added an ability to add a new contributor + html improvements * removed redundant code * fixed permissions * fixed test * added an ability to add multiple contributors + handle some edge cases * removed redundant conversion * flake8 fix --------- Co-authored-by: Yuhuai Liu <[email protected]>
…d contributors (CenterForOpenScience#11362) * osf admin can recreate preprint version 1 with unregistered contributors * fix test (CenterForOpenScience#11394) * fix test * fix other serializers * linting * osf admin can recreate preprint version 1 with unregistered contributors --------- Co-authored-by: Yuhuai Liu <[email protected]>
…rOpenScience#11401) * Add ability for registration created date to be changed in admin * Add form * added log for registration date updated action in admin * Add REGISTRATION_DATE_UPDATED to activity logs --------- Co-authored-by: Ihor Sokhan <[email protected]>
…ubscriptions [ENG-9666] (CenterForOpenScience#11418)
…(Registrations, Preprints, Collections, Institutions) in admin (CenterForOpenScience#11373) * Refactor provider admin/moderator management * add preprint provider admin/moderator tests
…tate) from the database (CenterForOpenScience#11330) * hard-delete draft preprint versions * check if user is staff before deleting preprint * remove breakpoint * fix tests
* link: documentation for this endpoint Signed-off-by: Josh Soref <[email protected]> * link: download the contents of this repository Signed-off-by: Josh Soref <[email protected]> * link: files in this repo Signed-off-by: Josh Soref <[email protected]> * link: disconnect your GitLab account and reconnect with a valid token Signed-off-by: Josh Soref <[email protected]> * link: more information on locations Signed-off-by: Josh Soref <[email protected]> * link: example of a full custom taxonomy and more information about each field Signed-off-by: Josh Soref <[email protected]> * link: set a password Signed-off-by: Josh Soref <[email protected]> * link: questions and comments Signed-off-by: Josh Soref <[email protected]> * link: blank version of the Election Research Preacceptance Competition form Signed-off-by: Josh Soref <[email protected]> * link: review the request Signed-off-by: Josh Soref <[email protected]> * link: disable this feature Signed-off-by: Josh Soref <[email protected]> * link: OSF Storage capacity Signed-off-by: Josh Soref <[email protected]> * link: Version history for this policy Signed-off-by: Josh Soref <[email protected]> * link: view it as a contributor Signed-off-by: Josh Soref <[email protected]> * link: withdraw its parent registration Signed-off-by: Josh Soref <[email protected]> * link: resend your confirmation email Signed-off-by: Josh Soref <[email protected]> * link: set a password for your account Signed-off-by: Josh Soref <[email protected]> * link: approve this ... Signed-off-by: Josh Soref <[email protected]> * link: View your draft Signed-off-by: Josh Soref <[email protected]> * link: Review and contribute to the updates in progress Signed-off-by: Josh Soref <[email protected]> * link: Review the updates in progress Signed-off-by: Josh Soref <[email protected]> * link: Review and either approve or reject the submitted updates Signed-off-by: Josh Soref <[email protected]> * link: Review the submited updates Signed-off-by: Josh Soref <[email protected]> * link: about preregistration Signed-off-by: Josh Soref <[email protected]> * link: list of storage provider keys Signed-off-by: Josh Soref <[email protected]> * Remove bogus aria-label Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]>
* spelling: dashed Signed-off-by: Josh Soref <[email protected]> * spelling: data for Signed-off-by: Josh Soref <[email protected]> * spelling: database Signed-off-by: Josh Soref <[email protected]> * spelling: datacite Signed-off-by: Josh Soref <[email protected]> * spelling: decode Signed-off-by: Josh Soref <[email protected]> * spelling: deleted Signed-off-by: Josh Soref <[email protected]> * spelling: delimiters Signed-off-by: Josh Soref <[email protected]> * spelling: descendents Signed-off-by: Josh Soref <[email protected]> * spelling: description Signed-off-by: Josh Soref <[email protected]> * spelling: desynchronized Signed-off-by: Josh Soref <[email protected]> * spelling: development Signed-off-by: Josh Soref <[email protected]> * spelling: dictionaries Signed-off-by: Josh Soref <[email protected]> * spelling: disconnect Signed-off-by: Josh Soref <[email protected]> * spelling: distinguishing Signed-off-by: Josh Soref <[email protected]> * spelling: draggable Signed-off-by: Josh Soref <[email protected]> * spelling: each Signed-off-by: Josh Soref <[email protected]> * spelling: educational Signed-off-by: Josh Soref <[email protected]> * spelling: effects tested Signed-off-by: Josh Soref <[email protected]> * spelling: efficient Signed-off-by: Josh Soref <[email protected]> * spelling: elsewhere Signed-off-by: Josh Soref <[email protected]> * spelling: embargoed Signed-off-by: Josh Soref <[email protected]> * spelling: endpoint Signed-off-by: Josh Soref <[email protected]> * spelling: engagement Signed-off-by: Josh Soref <[email protected]> * spelling: enqueues Signed-off-by: Josh Soref <[email protected]> * spelling: entire Signed-off-by: Josh Soref <[email protected]> * spelling: entries Signed-off-by: Josh Soref <[email protected]> * spelling: error Signed-off-by: Josh Soref <[email protected]> * spelling: exactly Signed-off-by: Josh Soref <[email protected]> * spelling: exceeds Signed-off-by: Josh Soref <[email protected]> * spelling: existence Signed-off-by: Josh Soref <[email protected]> * spelling: existing Signed-off-by: Josh Soref <[email protected]> * spelling: expected Signed-off-by: Josh Soref <[email protected]> * spelling: explicit Signed-off-by: Josh Soref <[email protected]> * spelling: explicitly Signed-off-by: Josh Soref <[email protected]> * spelling: expression Signed-off-by: Josh Soref <[email protected]> * spelling: extension Signed-off-by: Josh Soref <[email protected]> * spelling: extract Signed-off-by: Josh Soref <[email protected]> * spelling: fall back Signed-off-by: Josh Soref <[email protected]> * spelling: fetch Signed-off-by: Josh Soref <[email protected]> * spelling: filter Signed-off-by: Josh Soref <[email protected]> * spelling: finalize Signed-off-by: Josh Soref <[email protected]> * spelling: flag Signed-off-by: Josh Soref <[email protected]> * spelling: flattened Signed-off-by: Josh Soref <[email protected]> * spelling: flexibility Signed-off-by: Josh Soref <[email protected]> * spelling: for Signed-off-by: Josh Soref <[email protected]> * spelling: from Signed-off-by: Josh Soref <[email protected]> * spelling: function Signed-off-by: Josh Soref <[email protected]> * spelling: further Signed-off-by: Josh Soref <[email protected]> * spelling: github Signed-off-by: Josh Soref <[email protected]> * spelling: gitlab Signed-off-by: Josh Soref <[email protected]> * spelling: given by the referrer Signed-off-by: Josh Soref <[email protected]> * spelling: gives users Signed-off-by: Josh Soref <[email protected]> * spelling: greatgreatgrandchild Signed-off-by: Josh Soref <[email protected]> * spelling: guarantee Signed-off-by: Josh Soref <[email protected]> * spelling: guid Signed-off-by: Josh Soref <[email protected]> * spelling: hierarchy Signed-off-by: Josh Soref <[email protected]> * spelling: hipaa Signed-off-by: Josh Soref <[email protected]> * spelling: how you Signed-off-by: Josh Soref <[email protected]> * spelling: icar Signed-off-by: Josh Soref <[email protected]> * spelling: id Signed-off-by: Josh Soref <[email protected]> * spelling: identifying Signed-off-by: Josh Soref <[email protected]> * spelling: images Signed-off-by: Josh Soref <[email protected]> * spelling: implicit Signed-off-by: Josh Soref <[email protected]> * spelling: in Signed-off-by: Josh Soref <[email protected]> * spelling: include Signed-off-by: Josh Soref <[email protected]> * spelling: includes Signed-off-by: Josh Soref <[email protected]> * spelling: indeed Signed-off-by: Josh Soref <[email protected]> * spelling: information Signed-off-by: Josh Soref <[email protected]> * spelling: initially Signed-off-by: Josh Soref <[email protected]> * spelling: initiation Signed-off-by: Josh Soref <[email protected]> * spelling: initiator Signed-off-by: Josh Soref <[email protected]> * spelling: input Signed-off-by: Josh Soref <[email protected]> * spelling: install them Signed-off-by: Josh Soref <[email protected]> * spelling: instantiate Signed-off-by: Josh Soref <[email protected]> * spelling: institution Signed-off-by: Josh Soref <[email protected]> * spelling: institutional Signed-off-by: Josh Soref <[email protected]> * spelling: institutions Signed-off-by: Josh Soref <[email protected]> * spelling: instructions Signed-off-by: Josh Soref <[email protected]> * spelling: interface Signed-off-by: Josh Soref <[email protected]> * spelling: interval Signed-off-by: Josh Soref <[email protected]> * spelling: into Signed-off-by: Josh Soref <[email protected]> * spelling: is contingent Signed-off-by: Josh Soref <[email protected]> * spelling: is Signed-off-by: Josh Soref <[email protected]> * spelling: its Signed-off-by: Josh Soref <[email protected]> * spelling: javascript Signed-off-by: Josh Soref <[email protected]> * spelling: jira Signed-off-by: Josh Soref <[email protected]> * spelling: jsonschema Signed-off-by: Josh Soref <[email protected]> * spelling: justification Signed-off-by: Josh Soref <[email protected]> * spelling: landing Signed-off-by: Josh Soref <[email protected]> * spelling: less Signed-off-by: Josh Soref <[email protected]> * spelling: loading Signed-off-by: Josh Soref <[email protected]> * spelling: log in Signed-off-by: Josh Soref <[email protected]> * spelling: log Signed-off-by: Josh Soref <[email protected]> * spelling: macos Signed-off-by: Josh Soref <[email protected]> * spelling: maintenance Signed-off-by: Josh Soref <[email protected]> * spelling: malformed Signed-off-by: Josh Soref <[email protected]> * spelling: management Signed-off-by: Josh Soref <[email protected]> * spelling: manipulated Signed-off-by: Josh Soref <[email protected]> * spelling: manipulation Signed-off-by: Josh Soref <[email protected]> * spelling: marked Signed-off-by: Josh Soref <[email protected]> * spelling: mechanism Signed-off-by: Josh Soref <[email protected]> * spelling: message Signed-off-by: Josh Soref <[email protected]> * spelling: metadata Signed-off-by: Josh Soref <[email protected]> * spelling: method Signed-off-by: Josh Soref <[email protected]> * spelling: methods Signed-off-by: Josh Soref <[email protected]> * spelling: millisecond Signed-off-by: Josh Soref <[email protected]> * spelling: milliseconds Signed-off-by: Josh Soref <[email protected]> * spelling: moderator Signed-off-by: Josh Soref <[email protected]> * spelling: moving Signed-off-by: Josh Soref <[email protected]> * spelling: multiple Signed-off-by: Josh Soref <[email protected]> * spelling: nonexistent Signed-off-by: Josh Soref <[email protected]> * spelling: normalize Signed-off-by: Josh Soref <[email protected]> * spelling: not Signed-off-by: Josh Soref <[email protected]> * spelling: notifications Signed-off-by: Josh Soref <[email protected]> * spelling: notify Signed-off-by: Josh Soref <[email protected]> * spelling: oauth Signed-off-by: Josh Soref <[email protected]> * spelling: objects Signed-off-by: Josh Soref <[email protected]> * spelling: occurred Signed-off-by: Josh Soref <[email protected]> * spelling: optional Signed-off-by: Josh Soref <[email protected]> * spelling: original Signed-off-by: Josh Soref <[email protected]> * spelling: other analytic Signed-off-by: Josh Soref <[email protected]> * spelling: others Signed-off-by: Josh Soref <[email protected]> * spelling: otherwise Signed-off-by: Josh Soref <[email protected]> * spelling: our Signed-off-by: Josh Soref <[email protected]> * spelling: overridden Signed-off-by: Josh Soref <[email protected]> * spelling: paragraphs Signed-off-by: Josh Soref <[email protected]> * spelling: parameter Signed-off-by: Josh Soref <[email protected]> * spelling: params Signed-off-by: Josh Soref <[email protected]> * spelling: particular Signed-off-by: Josh Soref <[email protected]> * spelling: permanently Signed-off-by: Josh Soref <[email protected]> * spelling: persistent Signed-off-by: Josh Soref <[email protected]> * spelling: pertaining Signed-off-by: Josh Soref <[email protected]> * spelling: please Signed-off-by: Josh Soref <[email protected]> * spelling: positioning Signed-off-by: Josh Soref <[email protected]> * spelling: preceded Signed-off-by: Josh Soref <[email protected]> * spelling: predictions Signed-off-by: Josh Soref <[email protected]> * spelling: preexisting Signed-off-by: Josh Soref <[email protected]> * spelling: preparing Signed-off-by: Josh Soref <[email protected]> * spelling: prepopulate Signed-off-by: Josh Soref <[email protected]> * spelling: preprint Signed-off-by: Josh Soref <[email protected]> * spelling: private Signed-off-by: Josh Soref <[email protected]> * spelling: probabilistic Signed-off-by: Josh Soref <[email protected]> * spelling: programmatically Signed-off-by: Josh Soref <[email protected]> * spelling: progress Signed-off-by: Josh Soref <[email protected]> * spelling: propagates Signed-off-by: Josh Soref <[email protected]> * spelling: provider Signed-off-by: Josh Soref <[email protected]> * spelling: receive Signed-off-by: Josh Soref <[email protected]> * spelling: received Signed-off-by: Josh Soref <[email protected]> * spelling: recommended Signed-off-by: Josh Soref <[email protected]> * spelling: recommender Signed-off-by: Josh Soref <[email protected]> * spelling: redirect Signed-off-by: Josh Soref <[email protected]> * spelling: referrer Signed-off-by: Josh Soref <[email protected]> * spelling: register Signed-off-by: Josh Soref <[email protected]> * spelling: registration Signed-off-by: Josh Soref <[email protected]> * spelling: registrations Signed-off-by: Josh Soref <[email protected]> * spelling: registrationschema Signed-off-by: Josh Soref <[email protected]> * spelling: remaining Signed-off-by: Josh Soref <[email protected]> * spelling: remembered Signed-off-by: Josh Soref <[email protected]> * spelling: remnants Signed-off-by: Josh Soref <[email protected]> * spelling: replace Signed-off-by: Josh Soref <[email protected]> * spelling: represent Signed-off-by: Josh Soref <[email protected]> * spelling: request Signed-off-by: Josh Soref <[email protected]> * spelling: requires Signed-off-by: Josh Soref <[email protected]> * spelling: resolve Signed-off-by: Josh Soref <[email protected]> * spelling: resources Signed-off-by: Josh Soref <[email protected]> * spelling: response Signed-off-by: Josh Soref <[email protected]> * spelling: responses Signed-off-by: Josh Soref <[email protected]> * spelling: responsible Signed-off-by: Josh Soref <[email protected]> * spelling: results Signed-off-by: Josh Soref <[email protected]> * spelling: retain Signed-off-by: Josh Soref <[email protected]> * spelling: retrieve Signed-off-by: Josh Soref <[email protected]> * spelling: retrieves Signed-off-by: Josh Soref <[email protected]> * spelling: returned Signed-off-by: Josh Soref <[email protected]> * spelling: reversion Signed-off-by: Josh Soref <[email protected]> * spelling: rolled_back Signed-off-by: Josh Soref <[email protected]> * spelling: rules Signed-off-by: Josh Soref <[email protected]> * spelling: sanitization Signed-off-by: Josh Soref <[email protected]> * spelling: sanitize Signed-off-by: Josh Soref <[email protected]> * spelling: save Signed-off-by: Josh Soref <[email protected]> * spelling: scenario Signed-off-by: Josh Soref <[email protected]> * spelling: schema Signed-off-by: Josh Soref <[email protected]> * spelling: screen Signed-off-by: Josh Soref <[email protected]> * spelling: sendgrid Signed-off-by: Josh Soref <[email protected]> * spelling: separate Signed-off-by: Josh Soref <[email protected]> * spelling: serialized Signed-off-by: Josh Soref <[email protected]> * spelling: set up Signed-off-by: Josh Soref <[email protected]> * spelling: setting Signed-off-by: Josh Soref <[email protected]> * spelling: should Signed-off-by: Josh Soref <[email protected]> * spelling: should_be Signed-off-by: Josh Soref <[email protected]> * spelling: situations Signed-off-by: Josh Soref <[email protected]> * spelling: something Signed-off-by: Josh Soref <[email protected]> * spelling: sorted Signed-off-by: Josh Soref <[email protected]> * spelling: specific Signed-off-by: Josh Soref <[email protected]> * spelling: study Signed-off-by: Josh Soref <[email protected]> * spelling: subclasses Signed-off-by: Josh Soref <[email protected]> * spelling: submissions Signed-off-by: Josh Soref <[email protected]> * spelling: submitted Signed-off-by: Josh Soref <[email protected]> * spelling: successful Signed-off-by: Josh Soref <[email protected]> * spelling: successfully Signed-off-by: Josh Soref <[email protected]> * spelling: super bowl Signed-off-by: Josh Soref <[email protected]> * spelling: supporting Signed-off-by: Josh Soref <[email protected]> * spelling: technically Signed-off-by: Josh Soref <[email protected]> * spelling: technique Signed-off-by: Josh Soref <[email protected]> * spelling: template Signed-off-by: Josh Soref <[email protected]> * spelling: test Signed-off-by: Josh Soref <[email protected]> * spelling: than Signed-off-by: Josh Soref <[email protected]> * spelling: that a Signed-off-by: Josh Soref <[email protected]> * spelling: that the Signed-off-by: Josh Soref <[email protected]> * spelling: that Signed-off-by: Josh Soref <[email protected]> * spelling: the p-values Signed-off-by: Josh Soref <[email protected]> * spelling: the sample Signed-off-by: Josh Soref <[email protected]> * spelling: the Signed-off-by: Josh Soref <[email protected]> * spelling: there are Signed-off-by: Josh Soref <[email protected]> * spelling: there Signed-off-by: Josh Soref <[email protected]> * spelling: threshold Signed-off-by: Josh Soref <[email protected]> * spelling: through table Signed-off-by: Josh Soref <[email protected]> * spelling: timed out Signed-off-by: Josh Soref <[email protected]> * spelling: transactional Signed-off-by: Josh Soref <[email protected]> * spelling: transition Signed-off-by: Josh Soref <[email protected]> * spelling: trench coat Signed-off-by: Josh Soref <[email protected]> * spelling: triangles Signed-off-by: Josh Soref <[email protected]> * spelling: unflag Signed-off-by: Josh Soref <[email protected]> * spelling: unique Signed-off-by: Josh Soref <[email protected]> * spelling: uniqueness Signed-off-by: Josh Soref <[email protected]> * spelling: unit tests Signed-off-by: Josh Soref <[email protected]> * spelling: universally Signed-off-by: Josh Soref <[email protected]> * spelling: unmoderated Signed-off-by: Josh Soref <[email protected]> * spelling: unnecessary Signed-off-by: Josh Soref <[email protected]> * spelling: unstructured Signed-off-by: Josh Soref <[email protected]> * spelling: unverified Signed-off-by: Josh Soref <[email protected]> * spelling: updated Signed-off-by: Josh Soref <[email protected]> * spelling: user Signed-off-by: Josh Soref <[email protected]> * spelling: username Signed-off-by: Josh Soref <[email protected]> * spelling: users Signed-off-by: Josh Soref <[email protected]> * spelling: verifications Signed-off-by: Josh Soref <[email protected]> * spelling: version Signed-off-by: Josh Soref <[email protected]> * spelling: versions Signed-off-by: Josh Soref <[email protected]> * spelling: view Signed-off-by: Josh Soref <[email protected]> * spelling: waffle Signed-off-by: Josh Soref <[email protected]> * spelling: waterbutler Signed-off-by: Josh Soref <[email protected]> * spelling: website Signed-off-by: Josh Soref <[email protected]> * spelling: weight Signed-off-by: Josh Soref <[email protected]> * spelling: when Signed-off-by: Josh Soref <[email protected]> * spelling: whether or not Signed-off-by: Josh Soref <[email protected]> * spelling: whether Signed-off-by: Josh Soref <[email protected]> * spelling: which Signed-off-by: Josh Soref <[email protected]> * spelling: with Signed-off-by: Josh Soref <[email protected]> * spelling: withdrawn Signed-off-by: Josh Soref <[email protected]> * spelling: won't Signed-off-by: Josh Soref <[email protected]> * spelling: your profile be visible Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]>
…ints (CenterForOpenScience#11371) * added systems tags management in admin for nodes and preprints * added the ability to remove tags from nodes/registrations/preprints/users
* Implement BaseFileNode for azure blob storage * fix review comments --------- Co-authored-by: An Qiuyu <[email protected]>
## Purpose - Update LICENSE file for 2025
…requests (POST/PATCH) (CenterForOpenScience#11452) ## Purpose enable bulk request for registration contributors POST/PATCH
* Update fix * add manage command to manual reindex preprints
ad2daf2 to
ecd3ede
Compare
…flow it looks to be impossible 'why_no_prereg' be empty and 'prereg_links' exists simultaniously)
ecd3ede to
4bb3a42
Compare
Contributor
ihorsokhanexoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
Contributor
|
looks good |
Collaborator
|
@mkovalua Please rebase this onto the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When attempting to create a new version of a preprint, user received the following error message:
"You cannot edit this statement while your prereg links availability is set to true or is unanswered."
Example:
https://osf.io/preprints/psyarxiv/jkfsx_v1
User has https://osf.io/preprints/psyarxiv/jkfsx_v1 linked in the prereg section of the preprint
When user goes to either edit or create new version they receive the same error message. User is unable to adjust any settings leads me back to the same error message. User tried multiple browsers and logging in/out.
Support team was unable to reproduce on test.
Changes
check prereg_links exists before raising exception (for current workflow it looks to be impossible 'why_no_prereg' be empty and 'prereg_links' exists simultaniously)
for now
we can have either
why_no_preregorhas_prereg_linksandprereg_linksset simultaniouslyand it is impossible to set all the records like it for record https://osf.io/preprints/psyarxiv/jkfsx_v1 and maybe some other records
QA Notes
Not succeeed to reproduce the issue for staging
have tried to hardcode preprint antributes that is for https://osf.io/preprints/psyarxiv/jkfsx_v1 on local testing
c524-6c06-4c9e-a837-ad5933bb2d8f.1.1.mp4
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9727