Repository navigation
feat(js): add exact BigInt conversions, toI128LowBits and fromWords - #91
Open
nazarhussain wants to merge 4 commits into
Open
nazarhussain wants to merge 4 commits into
nazarhussain wants to merge 4 commits into
Conversation
napi fills the low-order words and the sign even when the BigInt needs more words than the buffer holds. Setting sign_bit before returning error.Overflow lets callers catch the error and read the truncated value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BigInt.toI64Exact and BigInt.toU64Exact return error.Overflow when the value does not fit, instead of the low 64 bits toI64/toU64 return. BigInt.toI128LowBits returns BigInt.asIntN(128) semantics. Existing methods are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The fuzz harness in #41 needs exact BigInt conversions and word-level construction. These are the non-breaking parts of #83, so #41 can merge without waiting for the breaking change.
Description
Adds
BigInt.toI64Exact/toU64Exact(throwOverflowinstead of returning low bits),BigInt.toI128LowBits(BigInt.asIntN(128)) andBigInt.fromWords. It also fixesgetValueBigintWordsleavingsign_bitunset on overflow, and documents N-APINumberconversion semantics. Existing methods are unchanged.🤖 Generated with Claude Code