Skip to content

drop bincode#38

Merged
NoEgAm merged 2 commits intomainfrom
drop-bincode
Apr 9, 2026
Merged

drop bincode#38
NoEgAm merged 2 commits intomainfrom
drop-bincode

Conversation

@tiye
Copy link
Copy Markdown
Member

@tiye tiye commented Mar 29, 2026

No description provided.

@tiye tiye requested review from a team and Copilot March 29, 2026 14:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the bincode dependency and related encode/decode usage, keeping serde support and updating examples accordingly.

Changes:

  • Drop bincode from dependencies and remove Decode/Encode derives/imports.
  • Update examples to validate serde Serialize/Deserialize trait availability instead of bincode roundtrips.
  • Simplify a few pattern-matching blocks using Rust let-chains.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/tree.rs Refactors comma/dollar detection logic using let-chains (no behavior change intended).
src/primes.rs Removes bincode derives/import; keeps serde impls; minor refactor in is_nested.
examples/test_features.rs Replaces bincode serialization demo with compile-time serde trait bound checks.
examples/feature_test.rs Same as above for the feature test example.
examples/bincode.rs Removes the bincode example binary.
Cargo.toml Bumps crate version and removes bincode dependency.
Cargo.lock Removes bincode and updates resolved dependency graph accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NoEgAm NoEgAm merged commit 1efc77b into main Apr 9, 2026
1 check passed
@NoEgAm NoEgAm deleted the drop-bincode branch April 9, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants