Skip to content

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Analyse and Refactor Functions#166

Closed
TarasMykytiuk wants to merge 6 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:sprint-1
Closed

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 1 | Analyse and Refactor Functions#166
TarasMykytiuk wants to merge 6 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:sprint-1

Conversation

@TarasMykytiuk

@TarasMykytiuk TarasMykytiuk commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Exercises for js and python are done.

@TarasMykytiuk TarasMykytiuk added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jun 12, 2026
cjyuan
cjyuan reviewed Jun 13, 2026
View reviewed changes
Comment thread Sprint-1/JavaScript/calculateSumAndProduct/calculateSumAndProduct.js Outdated
Comment thread Sprint-1/JavaScript/findCommonItems/findCommonItems.js Outdated
Comment thread Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js Outdated
Comment thread Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js Outdated
Comment thread Sprint-1/JavaScript/removeDuplicates/removeDuplicates.mjs Outdated
Comment thread Sprint-1/Python/find_common_items/find_common_items.py
Comment thread Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py Outdated
Comment thread Sprint-1/Python/remove_duplicates/remove_duplicates.py Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 13, 2026
@TarasMykytiuk

TarasMykytiuk commented Jun 28, 2026

Copy link
Copy Markdown
Author

Thanks for useful feedback!

@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 28, 2026
cjyuan
cjyuan reviewed Jun 28, 2026
View reviewed changes
Comment thread Sprint-1/Python/remove_duplicates/remove_duplicates.py Outdated
"""
unique_items = []

unique_items = set()

@cjyuan cjyuan Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is unused.

@TarasMykytiuk TarasMykytiuk Jun 28, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now removed.

@cjyuan cjyuan Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed it to set for a reason.

Comment thread Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py Outdated
Comment thread Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js Outdated
Comment thread Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 28, 2026
@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 28, 2026
cjyuan
cjyuan reviewed Jun 29, 2026
View reviewed changes
Comment thread Sprint-1/Python/remove_duplicates/remove_duplicates.py Outdated
Comment on lines +17 to +18
if value not in result:
result.append(value)

@cjyuan cjyuan Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The complexity of finding an item in a list is an O(n), making the complexity of this function O(N*N).

@TarasMykytiuk TarasMykytiuk Jun 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Now set also used here.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 29, 2026
@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 30, 2026
cjyuan
cjyuan reviewed Jun 30, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 30, 2026
@illicitonion

illicitonion commented Jun 30, 2026

Copy link
Copy Markdown
Member

Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Complexity The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TarasMykytiuk @illicitonion @cjyuan