Skip to content

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 2 | Improve with precomputing#185

Open
TarasMykytiuk wants to merge 4 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:improve_with_precomputing
Open

Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 2 | Improve with precomputing#185
TarasMykytiuk wants to merge 4 commits into
CodeYourFuture:mainfrom
TarasMykytiuk:improve_with_precomputing

Conversation

@TarasMykytiuk

@TarasMykytiuk TarasMykytiuk commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Improve with precomputing exercise completed.

@TarasMykytiuk TarasMykytiuk added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jun 28, 2026
cjyuan
cjyuan reviewed Jun 28, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Could you also use complexity to explain how the new algorithms are better than the original ones?

Comment thread Sprint-2/improve_with_precomputing/count_letters/count_letters.py
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 28, 2026
@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 28, 2026
@cjyuan

cjyuan commented Jun 28, 2026

Copy link
Copy Markdown

Could you also address the question in this comment: #185 (review)

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 28, 2026
@TarasMykytiuk TarasMykytiuk added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 30, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Complexity The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TarasMykytiuk @cjyuan