London | 26-SDC-Mar | beko | Sprint 2 | improve code with caches#190
Open
Abubakar-Meigag wants to merge 1 commit into
Open
London | 26-SDC-Mar | beko | Sprint 2 | improve code with caches#190Abubakar-Meigag wants to merge 1 commit into
Abubakar-Meigag wants to merge 1 commit into
Conversation
Abubakar-Meigag
added
📅 Sprint 2
cjyuan
reviewed
Jun 30, 2026
Comment on lines
+2
to
4
| cache = {} | ||
|
|
||
| def fibonacci(n): |
There was a problem hiding this comment.
Could you look into an approach that doesn't require keeping the cache in the global scope?
Change is optional.
Comment on lines
+11
to
+17
| coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| ways = [0] * (total + 1) | ||
| ways[0] = 1 | ||
|
|
||
| for coin in coins: | ||
| for amount in range(coin, total + 1): | ||
| ways[amount] += ways[amount - coin] |
There was a problem hiding this comment.
This iterative approach is quicker but it would beat the purpose of using cache to improve an existing recursive solution.
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, coins: List[int], coin_start_index: int = 0) -> int: |
There was a problem hiding this comment.
Even though you didn't use this helper function, you correctly implemented it to use a cache to improve the original implementation.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Completed improve code with caches