London | 26-ITP-JAN | Asha Ahmed | Sprint 2 | Data Groups - #1127
Closed
ashaahmed7 wants to merge 17 commits into
Closed
London | 26-ITP-JAN | Asha Ahmed | Sprint 2 | Data Groups#1127ashaahmed7 wants to merge 17 commits into
ashaahmed7 wants to merge 17 commits into
Conversation
…s, and multiple values per key
…ing '=', and edge cases
ashaahmed7
added
the
Needs Review
cjyuan
reviewed
Apr 1, 2026
Comment on lines
+6
to
+12
| for (let key in object) { | ||
| if (key === name) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; |
Contributor
There was a problem hiding this comment.
Can also considered Object.hasOwn().
Contributor
There was a problem hiding this comment.
Note: They are not entirely equivalent. You can explore their difference when you have time since it is a bit advanced for ITP.
cjyuan
added
Reviewed
…c; add test for array input
ashaahmed7
added
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the exercises in each directory on Sprint 2
Questions
N/A