London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | Quote Generator App - #1145
Closed
Zadri415 wants to merge 1 commit into
Closed
London | 26-ITP-Jan | Zadri Abdule | Sprint 3 | Quote Generator App#1145Zadri415 wants to merge 1 commit into
Zadri415 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Zadri415
changed the title
Zadri415
added
📅 Sprint 3
Luro91
added
Review in progress
Luro91
reviewed
Apr 6, 2026
Comment on lines
+39
to
+48
| if (autoPlayCheckbox) { | ||
| autoPlayCheckbox.addEventListener("change", (event) => { | ||
| if (event.target.checked) { | ||
| if (autoPlayStatus) autoPlayStatus.innerText = "Auto-Play: ON"; | ||
| autoPlayInterval = setInterval(generateQuote, 5000); | ||
| } else { | ||
| if (autoPlayStatus) autoPlayStatus.innerText = "Auto-Play: OFF"; | ||
| clearInterval(autoPlayInterval); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I don't see the autoplay checkbox on the web page
| function getRandomQuote(obj) { | ||
| const quoteEl = document.getElementById("quote"); | ||
| const authorEl = document.getElementById("author"); | ||
| if (!quoteEl || !authorEl) return; |
There was a problem hiding this comment.
Nice that you ensure the elements exist before using them
Luro91
added
Reviewed
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
quotes.js — added window.onload wiring: generateQuote(), New Quote button handler, Auto‑Play checkbox handling.
style.css — replaced/fixed CSS and applied a yellow/mustard palette for background, accents and buttons.
Questions
N/A