Skip to content

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Sprint3 /Quote generator - #1163

Closed
marthak1 wants to merge 6 commits into
CodeYourFuture:mainfrom
marthak1:coursework/sprint-3
Closed

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Sprint3 /Quote generator#1163
marthak1 wants to merge 6 commits into
CodeYourFuture:mainfrom
marthak1:coursework/sprint-3

Conversation

@marthak1

@marthak1 marthak1 commented Apr 2, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Built quote generator app as per assignment requirements

@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 2, 2026
Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment thread Sprint-3/quote-generator/quotes.js Outdated
Comment on lines +507 to +510
displayQuote();

// Change quote when button is clicked
button.addEventListener("click", displayQuote); No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placing all the "run on load" code in one place is a good practice.
Would be even better to place the code
inside a function to make it clearer that "this is what runs when the page loads."

For examples,

function setup() {
  // code to be executed on page load
}

window.addEventListener('load', setup);

or

window.addEventListener('load', function() {
  // code to be executed on page load
});

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feed, onl page load function added

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 3, 2026
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
@cjyuan

cjyuan commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

All good!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 6, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants