London | 26-ITP-May | Vito Moratti | Sprint 3 | Alarm-clock - #1384
Open
vmoratti wants to merge 9 commits into
Open
London | 26-ITP-May | Vito Moratti | Sprint 3 | Alarm-clock#1384vmoratti wants to merge 9 commits into
vmoratti wants to merge 9 commits into
Conversation
vmoratti
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 8, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
- If the user clicks "Stop Alarm" before the timer reaches 00:00, what happens to the countdown? Will the alarm still ring when the timer finishes?
- Could formatTime() do its job by returning the formatted time instead of relying on and updating global variables?
hey-hammad
added
Reviewed
Refactor formatTime function to accept remainingSeconds as a parameter and return formatted time string. Update alarm display logic to use the new formatTime function.
Author
|
I have now made the recommended adjustments. |
vmoratti
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 10, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Nice effort fixing the application state, few changes required regarding code quality.
| //5. starts timer | ||
| clearInterval(timer); | ||
| remainingSeconds = Number(document.getElementById("alarmSet").value); | ||
| if (remainingSeconds === 0) { |
There was a problem hiding this comment.
Is there a reason we're handling 0 and negative values separately here? Since both cases seem to represent invalid input, would it make sense to use a single validation check and provide user feedback (e.g., an alert/message) instead?
| } else if (remainingSeconds < 0) { | ||
| return clearInterval(timer); | ||
| } | ||
| formatTime(); |
There was a problem hiding this comment.
What's the purpose of the standalone formatTime() call here? It looks like the return value isn't used, and the formatted value is already generated in the next line.
| remainingSeconds = remainingSeconds - 1; | ||
| alarmDisplay.textContent = `Time Remaining: ${formatTime(remainingSeconds)}`; | ||
| } | ||
| function stopTimer() { |
There was a problem hiding this comment.
Is stopTimer() still needed? I don't see it being called anywhere.
Author
There was a problem hiding this comment.
the stopTime() function is being used by HTML file on line 16 by "Stop alarm" button.
hey-hammad
added
Reviewed
vmoratti
added
the
Needs Review
vmoratti
added
Needs Review
hey-hammad
added
Review in progress
hey-hammad
reviewed
Aug 11, 2026
| alarmDisplay.textContent = `Time Remaining: ${formatTime(remainingSeconds)}`; | ||
| timer = setInterval(updateDisplay, 1000); | ||
| } | ||
| function changeBackground() { |
There was a problem hiding this comment.
Is it possible to make this function act like a toggle? Currently it turns red and doesn't return to the original state when setting a new alarm.
Author
There was a problem hiding this comment.
I have made the adjustments to accommodate that
hey-hammad
suggested changes
Aug 11, 2026
hey-hammad
added
Reviewed
vmoratti
added
the
Needs Review
hey-hammad
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed implementation of the alarm clock