Skip to content

London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups - #1392

Open
mandipsanger wants to merge 11 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-1
Open

London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups#1392
mandipsanger wants to merge 11 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-1

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Aug 6, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

completed sprint 1 course work

Questions

N/A

@mandipsanger mandipsanger added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 6, 2026
LonMcGregor
LonMcGregor reviewed Aug 8, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, just one minor thing in dedupe

Comment thread Sprint-1/implement/dedupe.js
Comment thread Sprint-1/implement/dedupe.js Outdated
Comment thread Sprint-1/implement/max.js
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger| Sprint-1| Course work London | 26-ITP-May | Mandip Sanger| Sprint-1| Data Groups Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger| Sprint-1| Data Groups London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups Aug 10, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @LonMcGregor