Skip to content

London | 26-ITP-May | Ebrahim Moqbel | Sprint -1 | course work - #1393

Open
Ebrahim-Moqbel wants to merge 5 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-1
Open

London | 26-ITP-May | Ebrahim Moqbel | Sprint -1 | course work#1393
Ebrahim-Moqbel wants to merge 5 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-1

Conversation

@Ebrahim-Moqbel

@Ebrahim-Moqbel Ebrahim-Moqbel commented Aug 6, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

refactored the code for the files in sprint-1

Questions

N/A

@Ebrahim-Moqbel Ebrahim-Moqbel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Aug 6, 2026
LonMcGregor
LonMcGregor reviewed Aug 8, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this task is complete

Comment thread Sprint-1/implement/max.js
if (numbersOnly.length ===0 ){
return -Infinity
}
const sorted = [...numbersOnly].sort((a,b) => a-b)

@LonMcGregor LonMcGregor Aug 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to use sorting

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint -1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint -1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ebrahim-Moqbel @LonMcGregor