Skip to content

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Max - #1400

Open
KhotKeys wants to merge 2 commits into
CodeYourFuture:mainfrom
KhotKeys:max
Open

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Max#1400
KhotKeys wants to merge 2 commits into
CodeYourFuture:mainfrom
KhotKeys:max

Conversation

@KhotKeys

@KhotKeys KhotKeys commented Aug 7, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Implemented the findMax function that filters out non-numeric values and returns the largest number using Math.max.

  • Added tests covering an empty array, single number, positive and negative numbers, decimals, mixed types, and all non-numbers.

@KhotKeys KhotKeys added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2026
@LonMcGregor

Copy link
Copy Markdown

See my comment on #1398

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants