Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 2 | Form-Control by mo-omer · Pull Request #1184 · CodeYourFuture/Module-Onboarding

mo-omer · 2026-02-19T00:12:11Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

included semantic wrappers for better grouping form controls and simpler code.

netlify · 2026-02-19T00:12:17Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`0457884`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/699b4bfb71126000086bc13d
😎 Deploy Preview	https://deploy-preview-1184--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

hkavalikas · 2026-02-19T06:54:25Z

Form-Controls/index.html

+  </main>
+
+  <footer>
+    <p>Website Dedicated To T-shirt Sale</p>


We had slightly different requirements for the content of this footer. Let's check the edited files again and address it.

hkavalikas · 2026-02-19T07:05:59Z

Form-Controls/index.html

+        </p>
+      </section>
+
+      <!-- Colour Selection -->


Let's look into the colour selection a bit more, specifically the options. Do you see anything that might look off and not fulfil the requirements?

hkavalikas · 2026-02-19T07:08:38Z

Form-Controls/index.html

+            Red  
+          </label>
+
+          <p>


We are wrapping radio buttons into paragraphs, which might be a better fit for text. Can you find a more appropriate tag to wrap them instead?

hkavalikas · 2026-02-19T07:15:26Z

Form-Controls/index.html

+          </div>
+
+          <label>
+            <input type="radio" name="colour" value="red" required />


This radio button was declared in a slightly different way than others, it's not getting the CSS changes and doesn't fulfil the original requirements to be associated with the input. How can we improve it?

hkavalikas · 2026-02-19T07:21:02Z

Let's also improve the Changelist by listing what work has been done, generally speaking we should give a high-level summary of the changes over mentioning things like "simpler", "better" or "cleaner" code to help the reviewer get an idea of what they are about to review as well as serve as a sort of documentation if someone has to refer back to it in the future so they don't need to go through all files again to get an understanding of what has been changed.

cjyuan

According to https://validator.w3.org/, there is one warning. Can you address it?

cjyuan · 2026-02-22T13:18:28Z

Form-Controls/index.html

+            <div>
+              <input type="radio" id="red" name="colour" value="red" required />
+              <label for="red">Red</label>
+            </div>
+
+
+            <div>
+              <input type="radio" id="black" name="colour" value="black" required />
+              <label for="black">Black</label>
+            </div>


This implementation does not quite meet the requirements specified in README.md. Please check the spec to find out what you missed.

added 3rd colour section to meet README requirement

<div> <input type="radio" id="blue" name="colour" value="blue" required /> <label for="blue">Blue</label> </div>

cjyuan · 2026-02-22T13:21:11Z

Form-Controls/index.html

+              <input type="radio" id="xs" name="size" value="XS" required />
+              <label for="xs">XS</label>


Could also consider wrapping the radio button input inside the label tag as:

<labe> <input type="radio" name="size" value="XS" required /> XS </label>

This way, you don't need to use the for and id attribute.

Also, among the radio buttons in the same button group, we don't need multiple required -- one is enough.

wrapped radio button input inside label tag and removed redundant required, id and for attributes since label wrap inputs

<label> <input type="radio" name="size" value="XS" required /> XS </label>

cjyuan · 2026-02-22T13:33:58Z

@mo-omer
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  - You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
- Without this label, the reviewer would not know if your changes is ready to be reviewed.

cjyuan · 2026-02-22T16:46:11Z

According to https://validator.w3.org/, there is one warning. Can you address it? (I don't think the Submit button needs its own "section")
Why markup the radio buttons for colours and sizes in different syntax?

<input type="radio" id="blue" name="colour" value="blue" required />
<label for="blue">Blue</label>

<label>
  <input type="radio" name="size" value="M" /> M
</label>

mo-omer · 2026-02-22T18:41:26Z

According to https://validator.w3.org/, there is one warning. Can you address it? (I don't think the Submit button needs its own "section")

Why markup the radio buttons for colours and sizes in different syntax?
<input type="radio" id="blue" name="colour" value="blue" required />
<label for="blue">Blue</label>
<label>
  <input type="radio" name="size" value="M" /> M
</label>

changed syntax on radio button to match the rest
removed section tag from submit button

cjyuan · 2026-02-22T18:42:58Z

Changes look good. Well done.

mo-omer added 2 commits February 18, 2026 18:51

T-shirt Sale form

c0db975

semantic grouping

c0c462e

mo-omer added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 19, 2026

hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 19, 2026

hkavalikas self-requested a review February 19, 2026 06:52

hkavalikas suggested changes Feb 19, 2026

View reviewed changes

hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 19, 2026

mo-omer added 2 commits February 21, 2026 01:04

footer content

57c125a

Add spacing for improved readability in index.html

e2b9131

mo-omer added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 21, 2026

cjyuan reviewed Feb 22, 2026

View reviewed changes

colour section

504612c

mo-omer added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 22, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 22, 2026

syntacs change

0457884

mo-omer added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 22, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 22, 2026

mo-omer mentioned this pull request Feb 22, 2026

26-ITP-Jan | Onboarding | Mohammed Omer mo-omer/My-Coursework-Planner#9

Open

		<input type="radio" id="xs" name="size" value="XS" required />
		<label for="xs">XS</label>

Uh oh!

Comments

Conversation

mo-omer commented Feb 19, 2026

Changelist

Uh oh!

netlify bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

hkavalikas Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

hkavalikas Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

hkavalikas Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

hkavalikas Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

hkavalikas commented Feb 19, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mo-omer Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

mo-omer Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mo-omer commented Feb 22, 2026

Uh oh!

cjyuan commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Feb 19, 2026 •

edited

Loading

cjyuan Feb 22, 2026 •

edited

Loading

cjyuan commented Feb 22, 2026 •

edited

Loading

cjyuan commented Feb 22, 2026 •

edited

Loading