Manchester | 26-ITP-May | Abid Akhtar | Sprint 2 | Wireframe#1398
Open
AbidAkhtar-tech wants to merge 8 commits into
Open
Manchester | 26-ITP-May | Abid Akhtar | Sprint 2 | Wireframe#1398AbidAkhtar-tech wants to merge 8 commits into
AbidAkhtar-tech wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
AbidAkhtar-tech
changed the title
AbidAkhtar-tech
added
the
Needs Review
cjyuan
reviewed
Jun 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
- The footer and the article content could overlap, making the text difficult to read. Could you find a way to prevent the text from overlapping?
-
Could you look up the benefits of using a code formatter? I strongly recommend following this guide
to enable VS Code's "Format on Save" option or use its "Format Document" command. This will help ensure your code is consistently formatted and easier to read and maintain. -
You did a good job keeping your code error-free. However, the W3C Validator (https://validator.w3.org/) identifies a warning in your code. Could you revise your code to resolve this warning?
-
Could you restore the "Changelist" header in your PR description? It should be a level 2 header that looks like this:
Changelist
cjyuan
added
Reviewed
Author
|
I have made the required changes. Your review is appreciated. Thanks |
AbidAkhtar-tech
added
Needs Review
AbidAkhtar-tech
changed the title
AbidAkhtar-tech
changed the title
cjyuan
reviewed
Jun 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
- Can you position articles 2 and 3 side by side (With article 2 on the left of article 3)?
- When the screen size change, there is still a chance the footer content and the article content can overlap. Can you find a better way to prevent their text content from overlapping?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This PR completes the Wireframe task by creating a webpage that matches the provided wireframe layout. I used semantic HTML elements such as header, main, article, section, and footer.