London | 26-ITP-May | Eyob Zeray | Sprint 2 | Wireframe#1424
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eyob-tech
added
📅 Sprint 2
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is error free and well formatted, and page layout matches the wireframe well.
-
Can you replace the images and add links to the articles so that they have different images and links (to meet one of the requirements)?
-
The checkboxes in the PR description is not yet correctly formatted in Markdown syntax. Can you fix their syntax? (Related resource: GitHub Tasklist)
| <footer> | ||
| <p>This page covers README files, wireframes, and Git branches — | ||
| three essential concepts for every web developer.</p> | ||
| </footer> |
There was a problem hiding this comment.
Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.
For more info about enabling "Format on save" option on VS Code, please refer to this guide.
cjyuan
added
Reviewed
eyob-tech
added
Needs Review
eyob-tech
changed the title
|
Changes look good. Well done. |
cjyuan
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Wireframe project completed. It has 3 articles with 3 different images and links.