London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | wireframe#1436
London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | wireframe#1436codebyra wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
codebyra
added
the
Needs Review
|
@cjyuan, please assist me with a review of this PR. I saw your comments on deletion in the previous pull request that I closed. I am investigating it |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is error-free. Page layout matches the wireframe well.
It seems on some screen size, the footer is blocking part of the article (including the "Read More" links). Can you update the CSS to leave more gap between the footer and the articles?
| <main> | ||
| <article> | ||
| <img src="images/readme.png" alt="README documentation example" /> | ||
|
|
||
|
|
||
| <h2>What is a README File?</h2> | ||
|
|
||
| <p> |
There was a problem hiding this comment.
Code is not yet properly indented.
You may want to follow this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to keep your code consistently formatted.
There was a problem hiding this comment.
@cjyuan I have formatted the HTML document to ensure consistent indentation and updated the footer styling to prevent overlap with the article content and links.
cjyuan
added
Reviewed
codebyra
added
the
Needs Review
akeren
added
📅 Sprint 2
|
That's quite a big gap between the footer and the articles. Changes look good. |
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
This PR completes the Wireframe task by updating the page content and styling. I added articles explaining README files, wireframes, and Git branches, included relevant images for each topic, and updated the CSS to improve the page layout and presentation.