Skip to content

London | 25-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Wireframe#1437

Open
khaliun-dev wants to merge 3 commits into
CodeYourFuture:mainfrom
khaliun-dev:feature/wireframe
Open

London | 25-ITP-May | Khaliun Baatarkhuu | Sprint 2 | Wireframe#1437
khaliun-dev wants to merge 3 commits into
CodeYourFuture:mainfrom
khaliun-dev:feature/wireframe

Conversation

@khaliun-dev

@khaliun-dev khaliun-dev commented Jun 9, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added a semantic page structure using header, main, article, and footer elements.
  • Created three articles explaining README files, wireframes, and Git branches.
  • Added a unique image, heading, summary, and link to each article.
  • Styled the page using an external CSS file.
  • Implemented a grid layout matching the provided wireframe.
  • Fixed the footer to the bottom of the viewport.
  • Added alt text to all images to improve accessibility.

Questions

None so far.

Updated CSS variables and layout styles for improved design.
@khaliun-dev khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@netlify

netlify Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7e1a54a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a28815cd2fd5b00088d616d
😎 Deploy Preview https://deploy-preview-1437--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@khaliun-dev khaliun-dev added 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Jun 9, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you use different image for each article to meet one of the updated requirements?

  • The brief description given in the Changelist section does not quite tell people what you have changed in this PR. Can you make the description more specific?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
@khaliun-dev khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026
@cjyuan

cjyuan commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Looks good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants