Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 1 | Format clock edge cases

[AkliluMihtsun]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1197

Changelist

• I have added some edge cases to try the code
• I have tested the edge cases using the assert and test methods

[hey-hammad]

Good start. However, please consider the following:

• What would happen if I pass 1:00, 25:00, or foobar to the function?
• Consider adding test cases for invalid inputs as well.

Also, using lots of if/else statements can make the logic harder to follow. Is there a simpler way to solve this?

Think about how 24-hour to 12-hour conversion works:

• What determines whether it's AM or PM?
• How do we convert a 24-hour time to 12-hour time in everyday life?